Re: [PATCH 2/3] tools: Add amd_hdr_visual for manual HDR verification

Alex Hung
2026-03-18T20:16:09Z

On 3/18/26 14:13, vitaly prosyak wrote:
>    The file uses igt_main(), igt_fixture(), igt_subtest(), IGT_TEST_DESCRIPTION(),
>    and igt_assert*() -- this is a test, not a tool. IGT tools (e.g., intel_gpu_top,
>    amd_hdmi_compliance) typically have a regular main() with argument parsing. If
>    this is intentionally a test that requires manual visual confirmation, it should
>    go in tests/ (perhaps tests/amdgpu/), not tools/. If it must be a tool, decouple
>    it from the test framework.
>
>    Alternatively, if the intent is to keep the igt_main() pattern (as
>    amd_hdmi_compliance.c does), then IGT_TEST_DESCRIPTION() is acceptable but the
>    patch description should clarify this is a manual-verification test binary placed
>    in tools/ because it requires human interaction and shouldn't run in CI.

Thank. I will fix it in V2 after I can rebase to another WIP patch series.