From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 204666E020 for ; Wed, 5 Sep 2018 00:56:48 +0000 (UTC) Message-ID: <2469463c5fa78109ae302d79f3fedd8470700f54.camel@intel.com> From: Dhinakaran Pandiyan Date: Tue, 04 Sep 2018 17:56:01 -0700 In-Reply-To: <20180901041806.2627-3-rodrigo.vivi@intel.com> References: <20180901041806.2627-1-rodrigo.vivi@intel.com> <20180901041806.2627-3-rodrigo.vivi@intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/6] tools/dpcd_reg: Unify file handling. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dhinakaran.pandiyan@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Vivi , igt-dev@lists.freedesktop.org List-ID: T24gRnJpLCAyMDE4LTA4LTMxIGF0IDIxOjE4IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4g QmVzaWRlcyByZW1vdmluZyBmZXcgY29kZSBkdXBsaWNhdGlvbiB0aGlzIHdpbGwKPiBhbGxvdyB1 cyB0byByZWFkIG11bHRpcGxlIHJlZ3Mgd2l0aG91dCBoYXZpbmcKPiB0byBrZWVwIGNsb3Npbmcg YW5kIG9wZW5pbmcgdGhlIGZpbGUgZm9yIGV2ZXJ5Cj4gcmVhZC4KPiAKPiBDYzogVGFydW4gVnlh cyA8dGFydW4udnlhc0BpbnRlbC5jb20+Cj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5h a2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8 cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiAtLS0KPiAgdG9vbHMvZHBjZF9yZWcuYyB8IDk4ICsr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAtLQo+ICAxIGZp bGUgY2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL3Rvb2xzL2RwY2RfcmVnLmMgYi90b29scy9kcGNkX3JlZy5jCj4gaW5kZXggZDEzOTAw N2MuLjA5ZGE0MTA5IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2RwY2RfcmVnLmMKPiArKysgYi90b29s cy9kcGNkX3JlZy5jCj4gQEAgLTUzLDYxICs1Myw1NiBAQCBzdGF0aWMgdm9pZCBwcmludF91c2Fn ZShjaGFyICp0b29sLCBpbnQgaGVscCkKPiAgCWV4aXQoKGhlbHAgPT0gMSk/IEVYSVRfU1VDQ0VT UyA6IEVYSVRfRkFJTFVSRSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgZHBjZF9yZWFkKGNoYXIg KmRldmljZSwgY29uc3QgdWludDMyX3Qgb2Zmc2V0LCBzaXplX3QKPiBjb3VudCkKPiArc3RhdGlj IGludCBkcGNkX3JlYWQoaW50IGZkLCBjb25zdCB1aW50MzJfdCBvZmZzZXQsIHNpemVfdCBjb3Vu dCkKPiAgewo+IC0JaW50IGZkLCByZXQsIGk7Cj4gKwlpbnQgcmV0LCBpOwo+ICAJdm9pZCAqYnVm ID0gbWFsbG9jKHNpemVvZih1aW50OF90KSAqIGNvdW50KTsKPiAgCj4gKwlyZXQgPSBsc2Vlayhm ZCwgb2Zmc2V0LCBTRUVLX1NFVCk7CkRvZXMgdGhpcyBvZmZlciBhbnkgYmVuZWZpdCBvdmVyIHBy ZWFkKCkvcHdyaXRlKCk/Cgo+ICsJaWYgKHJldCA8IDApIHsKPiArCQlpZ3Rfd2FybigibHNlZWsg dG8gJTA0eCBmYWlsZWQhXG4iLCBvZmZzZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ ICAJaWYgKE5VTEwgIT0gYnVmKQo+ICAJCW1lbXNldChidWYsIDAsIHNpemVvZih1aW50OF90KSAq IGNvdW50KTsKPiAgCWVsc2Ugewo+ICAJCWlndF93YXJuKCJDYW4ndCBhbGxvY2F0ZSByZWFkIGJ1 ZmZlclxuIik7Cj4gLQkJcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiArCQlyZXR1cm4gLTE7Cj4gIAl9 Cj4gIAo+IC0JZmQgPSBvcGVuKGRldmljZSwgT19SRE9OTFkpOwo+IC0JaWYgKGZkID4gMCkgewo+ IC0JCXJldCA9IHByZWFkKGZkLCBidWYsIGNvdW50LCBvZmZzZXQpOwo+IC0JCWNsb3NlKGZkKTsK PiAtCQlpZiAocmV0ICE9IGNvdW50KSB7Cj4gLQkJCWlndF93YXJuKCJGYWlsZWQgdG8gcmVhZCBm cm9tICVzIGF1eCBkZXZpY2UKPiAtIGVycm9yICVzXG4iLCBkZXZpY2UsIHN0cmVycm9yKGVycm5v KSk7Cj4gLQkJCXJldCA9IEVYSVRfRkFJTFVSRTsKPiAtCQkJZ290byBvdXQ7Cj4gLQkJfQo+IC0K PiAtCQlpZ3RfaW5mbygiJTA0eDoiLCBvZmZzZXQpOwo+IC0JCWZvciAoaSA9IDA7IGkgPCBjb3Vu dDsgaSsrKQo+IC0JCQlpZ3RfaW5mbygiICUwMngiLCAqKCgodWludDhfdCAqKShidWYpKSArCj4g aSkpOwo+IC0JCWlndF9pbmZvKCJcbiIpOwo+IC0JfQo+IC0JZWxzZSB7Cj4gLQkJaWd0X3dhcm4o IkZhaWxlZCB0byBvcGVuICVzIGF1eCBkZXZpY2UgLSBlcnJvcjoKPiAlc1xuIiwgZGV2aWNlLCBz dHJlcnJvcihlcnJubykpOwo+IC0JCXJldCA9IEVYSVRfRkFJTFVSRTsKPiArCXJldCA9IHJlYWQo ZmQsIGJ1ZiwgY291bnQpOwo+ICsJaWYgKHJldCAhPSBjb3VudCkgewo+ICsJCWlndF93YXJuKCJG YWlsZWQgdG8gcmVhZCAtIGVycm9yICVzXG4iLAo+IHN0cmVycm9yKGVycm5vKSk7Cj4gKwkJZ290 byBvdXQ7Cj4gIAl9Cj4gKwo+ICsJaWd0X2luZm8oIiUwNHg6Iiwgb2Zmc2V0KTsKPiArCWZvciAo aSA9IDA7IGkgPCBjb3VudDsgaSsrKQo+ICsJCWlndF9pbmZvKCIgJTAyeCIsICooKCh1aW50OF90 ICopKGJ1ZikpICsgaSkpOwo+ICsJaWd0X2luZm8oIlxuIik7Cj4gKwo+ICBvdXQ6Cj4gIAlmcmVl KGJ1Zik7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGRwY2Rfd3JpdGUo Y2hhciAqZGV2aWNlLCBjb25zdCB1aW50MzJfdCBvZmZzZXQsIGNvbnN0Cj4gdWludDhfdCAqdmFs KQo+ICtzdGF0aWMgaW50IGRwY2Rfd3JpdGUoaW50IGZkLCBjb25zdCB1aW50MzJfdCBvZmZzZXQs IGNvbnN0IHVpbnQ4X3QKPiAqdmFsKQo+ICB7Cj4gLQlpbnQgZmQsIHJldDsKPiAtCj4gLQlmZCA9 IG9wZW4oZGV2aWNlLCBPX1JEV1IpOwo+IC0JaWYgKGZkID4gMCkgewo+IC0JCXJldCA9IHB3cml0 ZShmZCwgKGNvbnN0IHZvaWQgKil2YWwsIHNpemVvZih1aW50OF90KSwKPiBvZmZzZXQpOwo+IC0J CWNsb3NlKGZkKTsKPiAtCQlpZiAocmV0IDwgMCkgewo+IC0JCQlpZ3Rfd2FybigiRmFpbGVkIHRv IHdyaXRlIHRvICVzIGF1eCBkZXZpY2UgLQo+IGVycm9yICVzXG4iLCBkZXZpY2UsIHN0cmVycm9y KGVycm5vKSk7Cj4gLQkJCXJldCA9IEVYSVRfRkFJTFVSRTsKPiAtCQkJZ290byBvdXQ7Cj4gLQkJ fQo+IC0JCXJldCA9IGRwY2RfcmVhZChkZXZpY2UsIG9mZnNldCwgc2l6ZW9mKHVpbnQ4X3QpKTsK PiArCWludCByZXQ7Cj4gKwo+ICsJcmV0ID0gbHNlZWsoZmQsIG9mZnNldCwgU0VFS19TRVQpOwo+ ICsJaWYgKHJldCA8IDApIHsKPiArCQlpZ3Rfd2FybigibHNlZWsgdG8gJTA0eCBmYWlsZWQhXG4i LCBvZmZzZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gIAl9Cj4gLQllbHNlIHsKPiAtCQlpZ3Rfd2Fy bigiRmFpbGVkIHRvIG9wZW4gJXMgYXV4IGRldmljZSAtIGVycm9yOgo+ICVzXG4iLCBkZXZpY2Us IHN0cmVycm9yKGVycm5vKSk7Cj4gLQkJcmV0ID0gRVhJVF9GQUlMVVJFOwo+ICsKPiArCXJldCA9 IHdyaXRlKGZkLCAoY29uc3Qgdm9pZCAqKXZhbCwgc2l6ZW9mKHVpbnQ4X3QpKTsKPiArCWlmIChy ZXQgPCAwKSB7Cj4gKwkJaWd0X3dhcm4oIkZhaWxlZCB0byB3cml0ZSAtIGVycm9yICVzXG4iLAo+ IHN0cmVycm9yKGVycm5vKSk7Cj4gKwkJZ290byBvdXQ7Cj4gIAl9Cj4gKwlyZXQgPSBkcGNkX3Jl YWQoZmQsIG9mZnNldCwgc2l6ZW9mKHVpbnQ4X3QpKTsKPiAgb3V0Ogo+ICAJcmV0dXJuIHJldDsK PiAgfQo+IEBAIC0xMTUsMTAgKzExMCwxMSBAQCBvdXQ6Cj4gIGludCBtYWluKGludCBhcmdjLCBj aGFyICoqYXJndikKPiAgewo+ICAJY2hhciBkZXZfbmFtZVsyMF07Cj4gLQlpbnQgcmV0LCBkZXZp ZCwgaGVscF9mbGc7Cj4gKwlpbnQgZmQsIHJldCwgZGV2aWQsIGhlbHBfZmxnOwo+ICAJdWludDMy X3Qgb2Zmc2V0Owo+ICAJdWludDhfdCB2YWw7Cj4gIAlzaXplX3QgY291bnQ7Cj4gKwlpbnQgZmls ZV9vcCA9IE9fUkRPTkxZOwo+ICAKPiAgCWVudW0gY29tbWFuZCB7Cj4gIAkJSU5WID0gLTEsCj4g QEAgLTE1NywxMSArMTUzLDEyIEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAg CQkJYnJlYWs7Cj4gIAkJLyogQ29tbWFuZCBwYXJzaW5nICovCj4gIAkJY2FzZSAxOgo+IC0JCQlp ZiAoc3RyY21wKG9wdGFyZywgInJlYWQiKSA9PSAwKQo+ICsJCQlpZiAoc3RyY21wKG9wdGFyZywg InJlYWQiKSA9PSAwKSB7Cj4gIAkJCQljbWQgPSBSRUFEOwo+IC0JCQllbHNlIGlmIChzdHJjbXAo b3B0YXJnLCAid3JpdGUiKSA9PSAwKQo+ICsJCQl9IGVsc2UgaWYgKHN0cmNtcChvcHRhcmcsICJ3 cml0ZSIpID09IDApIHsKPiAgCQkJCWNtZCA9IFdSSVRFOwo+IC0JCQlicmVhazsKPiArCQkJCWZp bGVfb3AgPSBPX1JEV1I7Cj4gKwkJCX0gYnJlYWs7Cj4gIAkJY2FzZSAnOic6Cj4gIAkJCWlndF93 YXJuKCJUaGUgLSVjIG9wdGlvbiBvZiAlcyByZXF1aXJlcyBhbgo+IGFyZ3VtZW50XG4iLAo+ICAJ CQkJIG9wdG9wdCwgYXJndlswXSk7Cj4gQEAgLTE4NSwyMCArMTgyLDMzIEBAIGludCBtYWluKGlu dCBhcmdjLCBjaGFyICoqYXJndikKPiAgCW1lbXNldChkZXZfbmFtZSwgJ1wwJywgMjApOwo+ICAJ c25wcmludGYoZGV2X25hbWUsIHNpemVvZihhdXhfZGV2KSArIDIsICIlcyVkIiwgYXV4X2RldiwK PiBkZXZpZCk7Cj4gIAo+ICsJZmQgPSBvcGVuKGRldl9uYW1lLCBmaWxlX29wKTsKPiArCWlmIChm ZCA8IDApIHsKPiArCQlpZ3Rfd2FybigiRmFpbGVkIHRvIG9wZW4gJXMgYXV4IGRldmljZSAtIGVy cm9yOgo+ICVzXG4iLCBkZXZfbmFtZSwKPiArCQkJIHN0cmVycm9yKGVycm5vKSk7Cj4gKwkJcmV0 dXJuIEVYSVRfRkFJTFVSRTsKPiArCX0KPiArCj4gIAlzd2l0Y2ggKGNtZCkgewo+ICAJY2FzZSBS RUFEOgo+ICAJCWlmIChjb3VudCA9PSBJTlZBTElEKSB7Cj4gIAkJCWlndF93YXJuKCJQbGVhc2Ug c3BlY2lmeSB0aGUgY291bnQgaW4KPiBieXRlc1xuIik7Cj4gIAkJCXByaW50X3VzYWdlKGFyZ3Zb MF0sIDApOwo+ICAJCX0KPiAtCQlyZXQgPSBkcGNkX3JlYWQoZGV2X25hbWUsIG9mZnNldCwgY291 bnQpOwo+ICsJCXJldCA9IGRwY2RfcmVhZChmZCwgb2Zmc2V0LCBjb3VudCk7Cj4gKwkJaWYgKHJl dCAhPSBjb3VudCkKPiArCQkJaWd0X3dhcm4oIkZhaWxlZCB0byByZWFkIGZyb20gJXMgYXV4Cj4g ZGV2aWNlXG4iLAo+ICsJCQkJIGRldl9uYW1lKTsKPiAgCQlicmVhazsKPiAgCWNhc2UgV1JJVEU6 Cj4gIAkJaWYgKHZhbCA9PSBJTlZBTElEKSB7Cj4gIAkJCWlndF93YXJuKCJXcml0ZSB2YWx1ZSBp cyBtaXNzaW5nXG4iKTsKPiAgCQkJcHJpbnRfdXNhZ2UoYXJndlswXSwgMCk7Cj4gIAkJfQo+IC0J CXJldCA9IGRwY2Rfd3JpdGUoZGV2X25hbWUsIG9mZnNldCwgJnZhbCk7Cj4gKwkJcmV0ID0gZHBj ZF93cml0ZShmZCwgb2Zmc2V0LCAmdmFsKTsKPiArCQlpZiAocmV0IDwgMCkKPiArCQkJaWd0X3dh cm4oIkZhaWxlZCB0byB3cml0ZSB0byAlcyBhdXgKPiBkZXZpY2VcbiIsCj4gKwkJCQkgZGV2X25h bWUpOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBJTlY6Cj4gIAlkZWZhdWx0Ogo+IEBAIC0yMDYsNSAr MjE2LDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAJCXByaW50X3VzYWdl KGFyZ3ZbMF0sIDApOwo+ICAJfQo+ICAKPiArCWNsb3NlKGZkKTsKPiArCj4gIAlyZXR1cm4gcmV0 Owo+ICB9Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=