Re: [PATCH i-g-t] tests/kms_flip_scaled_crc: Move require checks at the beginning of the subtest

[Karthik B S <karthik.b.s@intel.com>]

Hi Kamil,

Thank you for the review. Will fix these during merge.

Thanks and Regards,
Karthik.B.S

On 1/29/2026 8:04 PM, Kamil Konieczny wrote:
> Hi Karthik,
> On 2026-01-21 at 10:51:58 +0530, Karthik B S wrote:
>
> add 'intel/' after 'test/' in subject:
>
> [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Move require checks at the beginning of the subtest
>
>> Previously, setup_fb() contained the igt_require() for format + modifier,
>> causing the dynamic test to be intialized only to skip eventually if the
> s/intialized/initialized/
>
>> combination is unsupported.
>> This patch moves format/modifier checks to the per-subtest level.
>>
>> Additionally, linear framebuffers combined with REFLECT_X rotation are
>> not supported on Intel platforms prior to gen35. To make this explicit and
>> reduce CI run time, the test now performs an early skip for this
>> combination, clearly stating the reason in the skip message.
> +cc Jeevan B <jeevan.b@intel.com>
>
>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>> ---
>>   tests/intel/kms_flip_scaled_crc.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/intel/kms_flip_scaled_crc.c b/tests/intel/kms_flip_scaled_crc.c
>> index 954b46b5f..91e5793f4 100644
>> --- a/tests/intel/kms_flip_scaled_crc.c
>> +++ b/tests/intel/kms_flip_scaled_crc.c
>> @@ -670,9 +670,6 @@ const struct {
>>   static void setup_fb(data_t *data, struct igt_fb *newfb, uint32_t width,
>>   		     uint32_t height, uint64_t format, uint64_t modifier)
>>   {
>> -	igt_require(igt_display_has_format_mod(&data->display, format,
>> -					       modifier));
>> -
>>   	igt_create_color_fb(data->drm_fd, width, height,
>>   			    format, modifier, 0, 1, 0, newfb);
>>   }
>> @@ -901,6 +898,18 @@ int igt_main()
>>   	for (int index = 0; index < ARRAY_SIZE(flip_scenario_test); index++) {
>>   		igt_describe(flip_scenario_test[index].describe);
>>   		igt_subtest_with_dynamic(flip_scenario_test[index].name) {
>> +			igt_require(igt_display_has_format_mod(&data.display,
>> +							       flip_scenario_test[index].firstformat,
>> +							       flip_scenario_test[index].firstmodifier));
>> +			igt_require(igt_display_has_format_mod(&data.display,
>> +							       flip_scenario_test[index].secondformat,
>> +							       flip_scenario_test[index].secondmodifier));
>> +
>> +			if(flip_scenario_test[index].secondmodifier == DRM_FORMAT_MOD_LINEAR &&
> Add space after 'if':
> 			if (flip_scenario_test[index].secondmodifier == DRM_FORMAT_MOD_LINEAR &&
>
>> +			   flip_scenario_test[index].secondrotation & IGT_REFLECT_X)
>> +				igt_require_f(data.gen >= 35,
>> +					      "Linear fb with REFLECT_X unsupported");
> Add newline at end of message:
> "Linear fb with REFLECT_X unsupported\n");
>
> Without it in report there is:
>
> Linear fb with REFLECT_X unsupportedSubtest flip-P016-linear-to-P016-linear-reflect-x: SKIP (0.000s)
>
> Regards,
> Kamil
>
>> +
>>   			free_fbs(&data);
>>   			for_each_pipe(&data.display, pipe) {
>>   				bool found = false;
>> -- 
>> 2.43.0
>>