From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: s/tiling/modifier/ where appropriate
Date: Wed, 31 Oct 2018 15:48:09 -0700 [thread overview]
Message-ID: <2648980.jNMChSksHr@dk-thinkpad-x260> (raw)
In-Reply-To: <20181030162038.27373-5-ville.syrjala@linux.intel.com>
On Tuesday, October 30, 2018 9:20:38 AM PDT Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Rename the igt_fb.tiling to igt_fb.modifier to better reflect
> what information it carries. Now it's clear whether we're talking
> about a modifier or a i915 tiling thing.
>
Makes sense,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
We should probably rename the locals in the callers for more clarity. kms_flip_tiling.c,
kms_rotation_crc.c, pm_rpm.c and kms_available_modes_crc.c store the modifier as
"tiling". Is this something that can be scripted easily?
-DK
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_fb.c | 102 ++++++++++++++++++++++++------------------------
> lib/igt_fb.h | 22 +++++------
> tests/kms_ccs.c | 2 +-
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-31 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 16:20 [igt-dev] [PATCH i-g-t 1/5] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Ville Syrjala
2018-10-30 16:20 ` [igt-dev] [PATCH i-g-t 2/5] tests/gem_render_copy: Test Yf tiling Ville Syrjala
2018-10-30 16:20 ` [igt-dev] [PATCH i-g-t 3/5] lib/igt_fb: Use rendercopy for rendering into compressed buffers Ville Syrjala
2018-10-30 16:20 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_plane: Test all modifiers as well Ville Syrjala
2018-10-31 21:35 ` Dhinakaran Pandiyan
2018-10-31 21:40 ` Ville Syrjälä
2018-10-30 16:20 ` [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: s/tiling/modifier/ where appropriate Ville Syrjala
2018-10-31 22:48 ` Dhinakaran Pandiyan [this message]
2018-10-30 16:44 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Patchwork
2018-10-30 20:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2648980.jNMChSksHr@dk-thinkpad-x260 \
--to=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox