From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 093686E81B for ; Fri, 19 Jul 2019 12:04:28 +0000 (UTC) From: "Ser, Simon" Date: Fri, 19 Jul 2019 12:04:26 +0000 Message-ID: <2660dd74ac46da3204852d9ce543cf5b14fb1695.camel@intel.com> References: <20190709122345.29180-3-arkadiusz.hiler@intel.com> <20190719120152.31193-1-arkadiusz.hiler@intel.com> In-Reply-To: <20190719120152.31193-1-arkadiusz.hiler@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v2 i-g-t 3/3] runner: Make sure that we are closing watchdogs on signals List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Hiler, Arkadiusz" , "igt-dev@lists.freedesktop.org" Cc: "Latvala, Petri" List-ID: T24gRnJpLCAyMDE5LTA3LTE5IGF0IDE1OjAxICswMzAwLCBBcmthZGl1c3ogSGlsZXIgd3JvdGU6 DQo+IFRoZXJlIGFyZSBmZXcgc2hvcnQgd2luZG93cyBvZiBvcHBvcnR1bml0eSB3aGVuIHdhdGNo ZG9ncyBhcmUgcHJpbWVkIGJ1dA0KPiB0aGVyZSBpcyBubyBzaWduYWwgaGFuZGxpbmcgaW4gcGxh Y2UsIHNvIHRoZSBwcm9jZXNzIG1heSBleGl0IHdpdGhvdXQNCj4gcHJvcGVyIHNodXRkb3duIHNl cXVlbmNlLg0KPiANCj4gVGhpcyBwYXRjaCByZWFycmFuZ2VzIHRoZSBleGlzdGluZyBjb2RlIHNv IHRoYXQgd2Ugc2V0IHVwIHRoZSBzaWduYWxmZA0KPiBhbmQgQkxPQ0sgdGhlIHNpZ25hbHMgYmVm b3JlIHNldHRpbmcgdXAgd2F0Y2hkb2dzIGFuZCBVTkJMT0NLIG9ubHkgYWZ0ZXINCj4gdGhlIHdh dGNoZG9ncyBhcmUgY2xvc2VkIHByb3Blcmx5Lg0KPiANCj4gSWYgaWd0X3J1bm5lciBleGl0cyBk dWUgdG8gc2lnbmFsLCBub24temVybyBzdGF0dXMgY29kZSBpcyByZXR1cm5lZC4NCj4gDQo+IHYy OiBtb3JlIGVycm9yIGhhbmRsaW5nIGFuZCBtaW5vciB0b3VjaCB1cHMgKFNpbW9uKQ0KPiANCj4g Q2M6IFBldHJpIExhdHZhbGEgPHBldHJpLmxhdHZhbGFAaW50ZWwuY29tPg0KPiBDYzogU2ltb24g U2VyIDxzaW1vbi5zZXJAaW50ZWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBBcmthZGl1c3ogSGls ZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+DQoNCkxHVE0sIHRoYW5rcyBmb3IgdGhlIGRl bHRhIQ0KDQpSZXZpZXdlZC1ieTogU2ltb24gU2VyIDxzaW1vbi5zZXJAaW50ZWwuY29tPg0KDQo+ IC0tLQ0KPiANCj4gIGRlbHRhIHdpdGggdjE6IGh0dHBzOi8vaGlsZXIuZXUvcC85ZDc5ZjczMC50 eHQNCj4gDQo+ICBydW5uZXIvZXhlY3V0b3IuYyB8IDEwNyArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgODAgaW5zZXJ0aW9u cygrKSwgMjcgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvcnVubmVyL2V4ZWN1dG9y LmMgYi9ydW5uZXIvZXhlY3V0b3IuYw0KPiBpbmRleCA2NDYzYWI5Ni4uNTJmZWU3ZDEgMTAwNjQ0 DQo+IC0tLSBhL3J1bm5lci9leGVjdXRvci5jDQo+ICsrKyBiL3J1bm5lci9leGVjdXRvci5jDQo+ IEBAIC03LDYgKzcsNyBAQA0KPiAgI2luY2x1ZGUgPHN0cmluZy5oPg0KPiAgI2luY2x1ZGUgPHN5 cy9pb2N0bC5oPg0KPiAgI2luY2x1ZGUgPHN5cy9zZWxlY3QuaD4NCj4gKyNpbmNsdWRlIDxzeXMv cG9sbC5oPg0KPiAgI2luY2x1ZGUgPHN5cy9zaWduYWxmZC5oPg0KPiAgI2luY2x1ZGUgPHN5cy9z dGF0Lmg+DQo+ICAjaW5jbHVkZSA8c3lzL3RpbWUuaD4NCj4gQEAgLTYwNCw3ICs2MDUsNiBAQCBz dGF0aWMgaW50IG1vbml0b3Jfb3V0cHV0KHBpZF90IGNoaWxkLA0KPiAgCQkJCWNsb3NlKG91dGZk KTsNCj4gIAkJCQljbG9zZShlcnJmZCk7DQo+ICAJCQkJY2xvc2Uoa21zZ2ZkKTsNCj4gLQkJCQlj bG9zZShzaWdmZCk7DQo+ICAJCQkJcmV0dXJuIC0xOw0KPiAgCQkJfQ0KPiAgDQo+IEBAIC03NzYs OSArNzc2LDggQEAgc3RhdGljIGludCBtb25pdG9yX291dHB1dChwaWRfdCBjaGlsZCwNCj4gIAkJ CQkJKnRpbWVfc3BlbnQgPSB0aW1lOw0KPiAgCQkJfQ0KPiAgDQo+IC0JCQljbG9zZShzaWdmZCk7 DQo+IC0JCQlzaWdmZCA9IC0xOw0KPiAgCQkJY2hpbGQgPSAwOw0KPiArCQkJc2lnZmQgPSAtMTsg Lyogd2UgYXJlIGR5aW5nLCBubyBzaWduYWwgaGFuZGxpbmcgZm9yIG5vdyAqLw0KPiAgCQl9DQo+ ICAJfQ0KPiAgDQo+IEBAIC03OTAsNyArNzg5LDYgQEAgc3RhdGljIGludCBtb25pdG9yX291dHB1 dChwaWRfdCBjaGlsZCwNCj4gIAljbG9zZShvdXRmZCk7DQo+ICAJY2xvc2UoZXJyZmQpOw0KPiAg CWNsb3NlKGttc2dmZCk7DQo+IC0JY2xvc2Uoc2lnZmQpOw0KPiAgDQo+ICAJaWYgKGFib3J0aW5n KQ0KPiAgCQlyZXR1cm4gLTE7DQo+IEBAIC05MDgsMTMgKzkwNiwxMiBAQCBzdGF0aWMgaW50IGV4 ZWN1dGVfbmV4dF9lbnRyeShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAJCQkgICAg ICBkb3VibGUgKnRpbWVfc3BlbnQsDQo+ICAJCQkgICAgICBzdHJ1Y3Qgc2V0dGluZ3MgKnNldHRp bmdzLA0KPiAgCQkJICAgICAgc3RydWN0IGpvYl9saXN0X2VudHJ5ICplbnRyeSwNCj4gLQkJCSAg ICAgIGludCB0ZXN0ZGlyZmQsIGludCByZXNkaXJmZCkNCj4gKwkJCSAgICAgIGludCB0ZXN0ZGly ZmQsIGludCByZXNkaXJmZCwNCj4gKwkJCSAgICAgIGludCBzaWdmZCwgc2lnc2V0X3QgKnNpZ21h c2spDQo+ICB7DQo+ICAJaW50IGRpcmZkOw0KPiAgCWludCBvdXRwdXRzW19GX0xBU1RdOw0KPiAg CWludCBrbXNnZmQ7DQo+IC0JaW50IHNpZ2ZkOw0KPiAtCXNpZ3NldF90IG1hc2s7DQo+ICAJaW50 IG91dHBpcGVbMl0gPSB7IC0xLCAtMSB9Ow0KPiAgCWludCBlcnJwaXBlWzJdID0geyAtMSwgLTEg fTsNCj4gIAlpbnQgb3V0ZmQsIGVycmZkOw0KPiBAQCAtOTU0LDIxICs5NTEsNiBAQCBzdGF0aWMg aW50IGV4ZWN1dGVfbmV4dF9lbnRyeShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAJ CWxzZWVrKGttc2dmZCwgMCwgU0VFS19FTkQpOw0KPiAgCX0NCj4gIA0KPiAtCXNpZ2VtcHR5c2V0 KCZtYXNrKTsNCj4gLQlzaWdhZGRzZXQoJm1hc2ssIFNJR0NITEQpOw0KPiAtCXNpZ2FkZHNldCgm bWFzaywgU0lHSU5UKTsNCj4gLQlzaWdhZGRzZXQoJm1hc2ssIFNJR1RFUk0pOw0KPiAtCXNpZ2Fk ZHNldCgmbWFzaywgU0lHUVVJVCk7DQo+IC0Jc2lnYWRkc2V0KCZtYXNrLCBTSUdIVVApOw0KPiAt CXNpZ3Byb2NtYXNrKFNJR19CTE9DSywgJm1hc2ssIE5VTEwpOw0KPiAtCXNpZ2ZkID0gc2lnbmFs ZmQoLTEsICZtYXNrLCBPX0NMT0VYRUMpOw0KPiAtDQo+IC0JaWYgKHNpZ2ZkIDwgMCkgew0KPiAt CQkvKiBUT0RPOiBIYW5kbGUgYmV0dGVyICovDQo+IC0JCWZwcmludGYoc3RkZXJyLCAiQ2Fubm90 IG1vbml0b3IgY2hpbGQgcHJvY2VzcyB3aXRoIHNpZ25hbGZkXG4iKTsNCj4gLQkJcmVzdWx0ID0g LTE7DQo+IC0JCWdvdG8gb3V0X2ttc2dmZDsNCj4gLQl9DQo+ICANCj4gIAlpZiAoc2V0dGluZ3Mt PmxvZ19sZXZlbCA+PSBMT0dfTEVWRUxfTk9STUFMKSB7DQo+ICAJCWNoYXIgKmRpc3BsYXluYW1l Ow0KPiBAQCAtMTAwMiw3ICs5ODQsNyBAQCBzdGF0aWMgaW50IGV4ZWN1dGVfbmV4dF9lbnRyeShz dHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAJCWNsb3NlKG91dHBpcGVbMF0pOw0KPiAg CQljbG9zZShlcnJwaXBlWzBdKTsNCj4gIA0KPiAtCQlzaWdwcm9jbWFzayhTSUdfVU5CTE9DSywg Jm1hc2ssIE5VTEwpOw0KPiArCQlzaWdwcm9jbWFzayhTSUdfVU5CTE9DSywgc2lnbWFzaywgTlVM TCk7DQo+ICANCj4gIAkJc2V0ZW52KCJJR1RfU0VOVElORUxfT05fU1RERVJSIiwgIjEiLCAxKTsN Cj4gIA0KPiBAQCAtMTI2MSwxMiArMTI0Myw0OCBAQCBzdGF0aWMgdm9pZCBvb21faW1tb3J0YWwo dm9pZCkNCj4gIAljbG9zZShmZCk7DQo+ICB9DQo+ICANCj4gK3N0YXRpYyBib29sIHNob3VsZF9k aWVfYmVjYXVzZV9zaWduYWwoaW50IHNpZ2ZkKQ0KPiArew0KPiArCXN0cnVjdCBzaWduYWxmZF9z aWdpbmZvIHNpZ2luZm87DQo+ICsJaW50IHJldDsNCj4gKwlzdHJ1Y3QgcG9sbGZkIHNpZ3BvbGwg PSB7IC5mZCA9IHNpZ2ZkLCAuZXZlbnRzID0gUE9MTElOIHwgUE9MTFJEQkFORCB9Ow0KPiArDQo+ ICsJcmV0ID0gcG9sbCgmc2lncG9sbCwgMSwgMCk7DQo+ICsNCj4gKwlpZiAocmV0ICE9IDApIHsN Cj4gKwkJaWYgKHJldCA9PSAtMSkgew0KPiArCQkJZnByaW50ZihzdGRlcnIsICJQb2xsIG9uIHNp Z25hbGZkIGZhaWxlZCB3aXRoICVzXG4iLCBzdHJlcnJvcihlcnJubykpOw0KPiArCQkJcmV0dXJu IHRydWU7IC8qIHNvbWV0aGluZyBpcyB3cm9uZywgbGV0J3MgZGllICovDQo+ICsJCX0NCj4gKw0K PiArCQlyZXQgPSByZWFkKHNpZ2ZkLCAmc2lnaW5mbywgc2l6ZW9mKHNpZ2luZm8pKTsNCj4gKw0K PiArCQlpZiAocmV0ID09IC0xKSB7DQo+ICsJCQlmcHJpbnRmKHN0ZGVyciwgIkVycm9yIHJlYWRp bmcgZnJvbSBzaWduYWxmZDogJXNcbiIsIHN0cmVycm9yKGVycm5vKSk7DQo+ICsJCQlyZXR1cm4g ZmFsc2U7IC8qIHdlIG1heSB3YW50IHRvIHJldHJ5IGxhdGVyICovDQo+ICsJCX0NCj4gKw0KPiAr CQlpZiAoc2lnaW5mby5zc2lfc2lnbm8gPT0gU0lHQ0hMRCkgew0KPiArCQkJZnByaW50ZihzdGRl cnIsICJSdW5uZXIgZ290IHN0cmF5IFNJR0NITEQgd2hpbGUgbm90IGV4ZWN1dGluZyBhbnkgdGVz dHMuXG4iKTsNCj4gKwkJfSBlbHNlIHsNCj4gKwkJCWZwcmludGYoc3RkZXJyLCAiUnVubmVyIGlz IGJlaW5nIGtpbGxlZCBieSAlc1xuIiwNCj4gKwkJCQlzdHJzaWduYWwoc2lnaW5mby5zc2lfc2ln bm8pKTsNCj4gKwkJCXJldHVybiB0cnVlOw0KPiArCQl9DQo+ICsNCj4gKwl9DQo+ICsNCj4gKwly ZXR1cm4gZmFsc2U7DQo+ICt9DQo+ICsNCj4gIGJvb2wgZXhlY3V0ZShzdHJ1Y3QgZXhlY3V0ZV9z dGF0ZSAqc3RhdGUsDQo+ICAJICAgICBzdHJ1Y3Qgc2V0dGluZ3MgKnNldHRpbmdzLA0KPiAgCSAg ICAgc3RydWN0IGpvYl9saXN0ICpqb2JfbGlzdCkNCj4gIHsNCj4gIAlzdHJ1Y3QgdXRzbmFtZSB1 bmFtZWJ1ZjsNCj4gIAlpbnQgcmVzZGlyZmQsIHRlc3RkaXJmZCwgdW5hbWVmZCwgdGltZWZkOw0K PiArCXNpZ3NldF90IHNpZ21hc2s7DQo+ICsJaW50IHNpZ2ZkOw0KPiAgCWRvdWJsZSB0aW1lX3Nw ZW50ID0gMC4wOw0KPiAgCWJvb2wgc3RhdHVzID0gdHJ1ZTsNCj4gIA0KPiBAQCAtMTMxMCw2ICsx MzI4LDIyIEBAIGJvb2wgZXhlY3V0ZShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZSAqc3RhdGUsDQo+ICAN Cj4gIAlvb21faW1tb3J0YWwoKTsNCj4gIA0KPiArCXNpZ2VtcHR5c2V0KCZzaWdtYXNrKTsNCj4g KwlzaWdhZGRzZXQoJnNpZ21hc2ssIFNJR0NITEQpOw0KPiArCXNpZ2FkZHNldCgmc2lnbWFzaywg U0lHSU5UKTsNCj4gKwlzaWdhZGRzZXQoJnNpZ21hc2ssIFNJR1RFUk0pOw0KPiArCXNpZ2FkZHNl dCgmc2lnbWFzaywgU0lHUVVJVCk7DQo+ICsJc2lnYWRkc2V0KCZzaWdtYXNrLCBTSUdIVVApOw0K PiArCXNpZ2ZkID0gc2lnbmFsZmQoLTEsICZzaWdtYXNrLCBPX0NMT0VYRUMpOw0KPiArCXNpZ3By b2NtYXNrKFNJR19CTE9DSywgJnNpZ21hc2ssIE5VTEwpOw0KPiArDQo+ICsJaWYgKHNpZ2ZkIDwg MCkgew0KPiArCQkvKiBUT0RPOiBIYW5kbGUgYmV0dGVyICovDQo+ICsJCWZwcmludGYoc3RkZXJy LCAiQ2Fubm90IG1hc2sgc2lnbmFsc1xuIik7DQo+ICsJCXN0YXR1cyA9IGZhbHNlOw0KPiArCQln b3RvIGVuZDsNCj4gKwl9DQo+ICsNCj4gIAlpbml0X3dhdGNoZG9ncyhzZXR0aW5ncyk7DQo+ICAN Cj4gIAlpZiAoIXVuYW1lKCZ1bmFtZWJ1ZikpIHsNCj4gQEAgLTEzNDUsMTIgKzEzNzksMTggQEAg Ym9vbCBleGVjdXRlKHN0cnVjdCBleGVjdXRlX3N0YXRlICpzdGF0ZSwNCj4gIAkJY2hhciAqcmVh c29uOw0KPiAgCQlpbnQgcmVzdWx0Ow0KPiAgDQo+ICsJCWlmIChzaG91bGRfZGllX2JlY2F1c2Vf c2lnbmFsKHNpZ2ZkKSkgew0KPiArCQkJc3RhdHVzID0gZmFsc2U7DQo+ICsJCQlnb3RvIGVuZDsN Cj4gKwkJfQ0KPiArDQo+ICAJCXJlc3VsdCA9IGV4ZWN1dGVfbmV4dF9lbnRyeShzdGF0ZSwNCj4g IAkJCQkJICAgIGpvYl9saXN0LT5zaXplLA0KPiAgCQkJCQkgICAgJnRpbWVfc3BlbnQsDQo+ICAJ CQkJCSAgICBzZXR0aW5ncywNCj4gIAkJCQkJICAgICZqb2JfbGlzdC0+ZW50cmllc1tzdGF0ZS0+ bmV4dF0sDQo+IC0JCQkJCSAgICB0ZXN0ZGlyZmQsIHJlc2RpcmZkKTsNCj4gKwkJCQkJICAgIHRl c3RkaXJmZCwgcmVzZGlyZmQsDQo+ICsJCQkJCSAgICBzaWdmZCwgJnNpZ21hc2spOw0KPiAgDQo+ ICAJCWlmIChyZXN1bHQgPCAwKSB7DQo+ICAJCQlzdGF0dXMgPSBmYWxzZTsNCj4gQEAgLTEzODMs OCArMTQyMywxNSBAQCBib29sIGV4ZWN1dGUoc3RydWN0IGV4ZWN1dGVfc3RhdGUgKnN0YXRlLA0K PiAgCQlpZiAocmVzdWx0ID4gMCkgew0KPiAgCQkJZG91YmxlIHRpbWVfbGVmdCA9IHN0YXRlLT50 aW1lX2xlZnQ7DQo+ICANCj4gLQkJCWNsb3NlKHRlc3RkaXJmZCk7DQo+ICAJCQljbG9zZV93YXRj aGRvZ3Moc2V0dGluZ3MpOw0KPiArCQkJc2lncHJvY21hc2soU0lHX1VOQkxPQ0ssICZzaWdtYXNr LCBOVUxMKTsNCj4gKwkJCS8qIG1ha2Ugc3VyZSB0aGF0IHdlIGRvIG5vdCBsZWF2ZSBhbnkgc2ln bmFscyB1bmhhbmRsZWQgKi8NCj4gKwkJCWlmIChzaG91bGRfZGllX2JlY2F1c2Vfc2lnbmFsKHNp Z2ZkKSkgew0KPiArCQkJCXN0YXR1cyA9IGZhbHNlOw0KPiArCQkJCWdvdG8gZW5kX3Bvc3Rfc2ln bmFsX3Jlc3RvcmU7DQo+ICsJCQl9DQo+ICsJCQljbG9zZShzaWdmZCk7DQo+ICsJCQljbG9zZSh0 ZXN0ZGlyZmQpOw0KPiAgCQkJaW5pdGlhbGl6ZV9leGVjdXRlX3N0YXRlX2Zyb21fcmVzdW1lKHJl c2RpcmZkLCBzdGF0ZSwgc2V0dGluZ3MsIGpvYl9saXN0KTsNCj4gIAkJCXN0YXRlLT50aW1lX2xl ZnQgPSB0aW1lX2xlZnQ7DQo+ICAJCQlyZXR1cm4gZXhlY3V0ZShzdGF0ZSwgc2V0dGluZ3MsIGpv Yl9saXN0KTsNCj4gQEAgLTEzOTcsOCArMTQ0NCwxNCBAQCBib29sIGV4ZWN1dGUoc3RydWN0IGV4 ZWN1dGVfc3RhdGUgKnN0YXRlLA0KPiAgCX0NCj4gIA0KPiAgIGVuZDoNCj4gLQljbG9zZSh0ZXN0 ZGlyZmQpOw0KPiAtCWNsb3NlKHJlc2RpcmZkKTsNCj4gIAljbG9zZV93YXRjaGRvZ3Moc2V0dGlu Z3MpOw0KPiArCXNpZ3Byb2NtYXNrKFNJR19VTkJMT0NLLCAmc2lnbWFzaywgTlVMTCk7DQo+ICsJ LyogbWFrZSBzdXJlIHRoYXQgd2UgZG8gbm90IGxlYXZlIGFueSBzaWduYWxzIHVuaGFuZGxlZCAq Lw0KPiArCWlmIChzaG91bGRfZGllX2JlY2F1c2Vfc2lnbmFsKHNpZ2ZkKSkNCj4gKwkJc3RhdHVz ID0gZmFsc2U7DQo+ICsgZW5kX3Bvc3Rfc2lnbmFsX3Jlc3RvcmU6DQo+ICsJY2xvc2Uoc2lnZmQp Ow0KPiArCWNsb3NlKHRlc3RkaXJmZCk7DQo+ICsJY2xvc2UocmVzZGlyZmQpOw0KPiAgCXJldHVy biBzdGF0dXM7DQo+ICB9DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=