Re: [igt-dev] [PATCH 0/2] Add Colorspace tests to kms_hdr

[Harry Wentland <harry.wentland@amd.com>]

On 12/30/22 15:06, Swati Sharma wrote:
> Hi Harry,
> 
> First of all, why do you think kms_hdr is the right place to add colorspace tests? Can we have amd specific IGT for the same.
> It seems intel doesn't have any plans in near future to expose this debugfs.
> ++Uma ++Bhanu
> 

kms_hdr includes the max_bpc tests added by Intel a while back. Colorspace
is similar. Both are mainly required for HDR.

This property and the test is generic in principle but I have not had a
chance to look more closely at the i915 driver to see how it should report
the current colorspace. It should be a straightforward change for an
i915 engineer.

Harry

> On 13-Dec-22 12:54 AM, Harry Wentland wrote:
>> We've had a Colorspace property on the drm_connector
>> but no IGT tests. These patches add IGT tests for this
>> property. They're currently only enabled on amdgpu with
>> the kernel at [1] but could be enabled for other drivers
>> if those drivers decide to expose a debugfs to read the
>> currently applied colorspace.
>>
>> [1] https://gitlab.freedesktop.org/hwentland/linux/-/tree/hdr-colorimetry>>>
>> Cc: Pekka Paalanen <ppaalanen@gmail.com>
>> Cc: Sebastian Wick <sebastian.wick@redhat.com>
>> Cc: Vitaly.Prosyak@amd.com
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Joshua Ashton <joshua@froggi.es>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>> Cc: Alex Hung <Alex.Hung@amd.com>
>>
>> Harry Wentland (2):
>>    tests/kms_hdr: Add test for output Colorspace
>>    tests/kms_hdr: Add suspend and DPMS Colorspace tests
>>
>>   lib/igt_kms.c   |  51 ++++++++++++++++
>>   lib/igt_kms.h   |   6 ++
>>   tests/kms_hdr.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 213 insertions(+)
>>
>> -- 
>> 2.38.1
>>
>