public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!
Date: Wed, 27 Mar 2019 06:16:17 +0000	[thread overview]
Message-ID: <268fd018-95f9-ec9a-a1fc-99280bfa091d@linux.intel.com> (raw)
In-Reply-To: <20190326185736.22835-1-chris@chris-wilson.co.uk>


On 26/03/2019 18:57, Chris Wilson wrote:
> Even with 128MiB reserved for other use, a single pass of gem_exec_big
> runs out of memory. Give in and halve our batch size, that has to be
> enough slack! As to why it keeps on failing, is left as an exercise to
> the reader -- we have to solve the mm/ mystery one day, as eventually it
> will be our only remaining source of bugs!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
>   tests/i915/gem_exec_big.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index 015f59e29..440136ee8 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -260,7 +260,7 @@ static void single(int i915)
>   	uint32_t handle;
>   	void *ptr;
>   
> -	batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
> +	batch_size = (intel_get_avail_ram_mb() / 2) << 20; /* XXX CI slack? */
>   	limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
>   	if (!gem_uses_full_ppgtt(i915))
>   		limit = 3 * limit / 4;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2019-03-27  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 18:57 [igt-dev] [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope! Chris Wilson
2019-03-26 19:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-27  4:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-27  6:16 ` Tvrtko Ursulin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=268fd018-95f9-ec9a-a1fc-99280bfa091d@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox