From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 4/4] lib/igt_fb: Generalize the slow read from gtt mmap handling
Date: Mon, 5 Nov 2018 16:33:28 +0100 [thread overview]
Message-ID: <281c75e8-6f99-50fc-756f-65add07328c0@linux.intel.com> (raw)
In-Reply-To: <20181105151929.pefmgc7rltfygaif@flea>
Op 05-11-18 om 16:19 schreef Maxime Ripard:
> On Fri, Nov 02, 2018 at 09:37:31PM +0200, Ville Syrjala wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Make the handling of slow gtt mmap reads generic, and extend it to
>> the pixman converter. Makes the pixman path a bit faster.
>>
>> With testing just XRGB8888 and XBGR8888 on KBL:
>> $ time kms_plane --r pixel-format-pipe-A-planes
>> - real 0m18,757s
>> + real 0m2,635s
>>
>> v2: Use the original src buffer if the malloc fails (Chris)
>> Drop the duplicated comment about things being slow
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> For the 4 patches,
> Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Thanks!
> Maxime
>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
I already had a similar fix to 1/4 in my tree but didn't send it out yet. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-05 15:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:06 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Fix the pixman converter Ville Syrjala
2018-11-02 19:06 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Assert converted formats harder Ville Syrjala
2018-11-02 19:06 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Use linear.fb in the converter Ville Syrjala
2018-11-02 19:06 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Generalize the slow read from gtt mmap handling Ville Syrjala
2018-11-02 19:17 ` Chris Wilson
2018-11-02 19:30 ` Ville Syrjälä
2018-11-02 19:32 ` Chris Wilson
2018-11-02 19:37 ` Ville Syrjälä
2018-11-02 19:37 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2018-11-05 15:19 ` Maxime Ripard
2018-11-05 15:33 ` Maarten Lankhorst [this message]
2018-11-05 15:41 ` Maxime Ripard
2018-11-05 16:07 ` Ville Syrjälä
2018-11-05 17:14 ` Maarten Lankhorst
2018-11-02 20:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Fix the pixman converter (rev2) Patchwork
2018-11-03 0:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=281c75e8-6f99-50fc-756f-65add07328c0@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maxime.ripard@bootlin.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox