From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "paul.kocialkowski@linux.intel.com" <paul.kocialkowski@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support
Date: Tue, 23 Apr 2019 13:09:57 +0000 [thread overview]
Message-ID: <2928dcec0ecacd3d471c70c0d7baf54770f7e9a1.camel@intel.com> (raw)
In-Reply-To: <155602083231.9039.17048491065121188664@skylake-alporthouse-com>
On Tue, 2019-04-23 at 13:00 +0100, Chris Wilson wrote:
> Quoting Ser, Simon (2019-04-23 12:45:05)
> > On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> > > Before asserting that the HDMI audio loopback works after resume, first
> > > require it to be present before suspend -- as not all machines are setup
> > > with the right HDMI audio capture.
> > >
> > > More strictly, one would expect that an audio capture device setup
> > > before suspend will remain functional after resume. An exercise left for
> > > the reader.
> >
> > What if audio works without suspend, but breaks with suspend? That new
> > test makes it less easy to understand whether audio works at all or if
> > it breaks because of suspend.
>
> That's the test; whether audio continues to work across suspend. It's
> the original test, not a new one.
>
> What the igt didn't (and still doesn't) do correctly is verify it has a
> working setup; for now we just assume that the driver is fine if igt_alsa
> fails. Turns a broken test from "DRIVER FAIL" to skip.
Oh, I mixed up igt_assert and igt_require again.
This patch does remove the hdmi-integrity test entirely though. We
probably want to keep it (or rather: we'd probably want to keep it if
it wasn't being removed in a patch that'll soon be merged).
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-23 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 7:52 [igt-dev] [PATCH i-g-t] tests/intel-ci: blacklist audio tests Simon Ser
2019-04-23 8:09 ` [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support Chris Wilson
2019-04-23 9:09 ` Chris Wilson
2019-04-23 11:45 ` Ser, Simon
2019-04-23 12:00 ` Chris Wilson
2019-04-23 13:09 ` Ser, Simon [this message]
2019-04-24 12:50 ` Jani Nikula
2019-04-25 11:12 ` Ser, Simon
2019-04-23 9:05 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel-ci: blacklist audio tests (rev2) Patchwork
2019-04-23 9:10 ` [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support Chris Wilson
2019-04-23 9:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel-ci: blacklist audio tests (rev3) Patchwork
2019-04-23 11:07 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/intel-ci: blacklist audio tests (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2928dcec0ecacd3d471c70c0d7baf54770f7e9a1.camel@intel.com \
--to=simon.ser@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox