Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Matthew Auld <matthew.auld@intel.com>, igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_ccs: fix bo size for ccs
Date: Mon, 18 Mar 2024 10:42:28 +0200	[thread overview]
Message-ID: <2ad7c886-a5c4-417e-bce3-4fb5aa473940@gmail.com> (raw)
In-Reply-To: <20240315162701.309560-1-matthew.auld@intel.com>

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 15.3.2024 18.27, Matthew Auld wrote:
> Don't just assume it will always fit into the default page size. When
> passing in custom -W or -H the raw CCS size could be larger than BO,
> leading to assertions.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>   tests/intel/xe_ccs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c
> index d6f5408a7..aec83a057 100644
> --- a/tests/intel/xe_ccs.c
> +++ b/tests/intel/xe_ccs.c
> @@ -108,7 +108,7 @@ static void surf_copy(int xe,
>   	const uint32_t bpp = 32;
>   	uint32_t bb1, bb2, ccs, ccs2, *ccsmap, *ccsmap2;
>   	uint64_t bb_size, ccssize = mid->size / CCS_RATIO(xe);
> -	uint64_t ccs_bo_size = xe_get_default_alignment(xe);
> +	uint64_t ccs_bo_size = ALIGN(ccssize, xe_get_default_alignment(xe));
>   	uint32_t *ccscopy;
>   	uint8_t uc_mocs = intel_get_uc_mocs_index(xe);
>   	uint32_t sysmem = system_memory(xe);


  parent reply	other threads:[~2024-03-18  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 16:27 [PATCH i-g-t] tests/intel/xe_ccs: fix bo size for ccs Matthew Auld
2024-03-15 17:11 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-15 17:33 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-18 12:34   ` Kamil Konieczny
2024-03-21  4:13     ` Illipilli, TejasreeX
2024-03-18  8:42 ` Juha-Pekka Heikkila [this message]
2024-03-20  6:35 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-20 17:36 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad7c886-a5c4-417e-bce3-4fb5aa473940@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox