From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] scripts/test_list: don't mangle directory names
Date: Fri, 5 May 2023 11:50:41 +0530 [thread overview]
Message-ID: <2ba632ff-2a64-7d1d-d2d5-a85fa6c467c2@intel.com> (raw)
In-Reply-To: <20230505053906.269572-1-mauro.chehab@linux.intel.com>
Hi Mauro,
On Fri-05-05-2023 11:09 am, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> While we want to standardize the testlist file names to use
> "-" instead of "_", such rule doesn't apply for the directory
> name.
>
> While here, make the replace regex more generic by replacing
> any non word/digit character sequences to "-".
>
> Reported-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> scripts/test_list.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index e7d486858eb4..a0db07125bc4 100755
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -1156,8 +1156,8 @@ class TestList:
> else:
> fname = testlist
>
> + fname = re.sub(r"[^\w\d]+", "-", fname)
> fname = directory + "/" + test_prefix + fname + ".testlist"
> - fname = re.sub(r"[\s_]+", "-", fname)
LGTM
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
- Bhanu
>
> with open(fname, 'w', encoding='utf8') as handler:
> for sub in test_subtests[test]:
next prev parent reply other threads:[~2023-05-05 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 5:39 [igt-dev] [PATCH i-g-t] scripts/test_list: don't mangle directory names Mauro Carvalho Chehab
2023-05-05 6:20 ` Modem, Bhanuprakash [this message]
2023-05-05 6:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-05 12:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba632ff-2a64-7d1d-d2d5-a85fa6c467c2@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mauro.chehab@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox