From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] testplan/meson.build: don't generate testlist on cross-compilation
Date: Thu, 27 Apr 2023 14:05:50 +0200 [thread overview]
Message-ID: <2ba8fe54-ed38-eb51-17f7-b601cc5fc15d@intel.com> (raw)
In-Reply-To: <20230427104119.198499-1-mauro.chehab@linux.intel.com>
On 27.04.2023 12:41, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> When doing cross-compilation, the binaries won't likely run at
> the builder machine. So, it is not possible to verify if there are
> documentation gaps.
>
> On such cases, skip checking it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> docs/testplan/meson.build | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
> index 3347f61876ef..e36713960ccd 100644
> --- a/docs/testplan/meson.build
> +++ b/docs/testplan/meson.build
> @@ -11,8 +11,13 @@ xe_test_config = join_paths(source_root, 'tests', 'xe', 'xe_test_config.json')
> check_testlist = []
> if build_tests
> doc_dependencies = test_executables
> - # Check if documentation matches the actual tests
> - check_testlist = [ '--check-testlist', '--igt-build-path', build_root ]
> + # Check if documentation matches the actual tests and tests can run
> + if not meson.is_cross_build()
> + build_info += 'Will Check if documentation is in sync with testlist'
> + check_testlist = [ '--check-testlist', '--igt-build-path', build_root ]
> + else
> + warning('WARNING: Will not check if documentation is in sync with testlist')
> + endif
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> else
> doc_dependencies = []
> endif
next prev parent reply other threads:[~2023-04-27 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 10:41 [igt-dev] [PATCH i-g-t 1/2] testplan/meson.build: don't generate testlist on cross-compilation Mauro Carvalho Chehab
2023-04-27 10:41 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_freq_api: add missing include Mauro Carvalho Chehab
2023-04-27 12:06 ` Andrzej Hajda
2023-04-27 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] testplan/meson.build: don't generate testlist on cross-compilation Patchwork
2023-04-27 12:05 ` Andrzej Hajda [this message]
2023-04-27 14:55 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba8fe54-ed38-eb51-17f7-b601cc5fc15d@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mauro.chehab@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox