Re: [PATCH i-g-t 5/6] tests/kms_flip: initialize global devid

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 24 Feb 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> Global variable devid is never initialize. Init it at start of the test.

It's never *used* so should be removed instead?

The other ones should be made static, and making them static reveals a
bunch of other unused variables:

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 49a5f4ed185f..e77a836be4d6 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -269,19 +269,15 @@
 
 static bool all_crtcs = false;
 
-drmModeRes *resources;
-int drm_fd;
+static drmModeRes *resources;
+static int drm_fd;
 static struct buf_ops *bops;
-uint32_t devid;
-int test_time = 3;
 static bool monotonic_timestamp;
 static pthread_t vblank_wait_thread;
 static int max_dotclock;
 
 static drmModeConnector *last_connector;
 
-uint32_t *fb_ptr;
-
 static igt_display_t display;
 
 struct type_name {




>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>  tests/kms_flip.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index ae38096aa..5b3c31ff5 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -2142,6 +2142,8 @@ int igt_main_args("cep", NULL, help_str, opt_handler, NULL)
>  	igt_fixture() {
>  		drm_fd = drm_open_driver_master(DRIVER_ANY);
>  
> +		devid = intel_get_drm_devid(drm_fd);
> +
>  		igt_display_require(&display, drm_fd);
>  
>  		kmstest_set_vt_graphics_mode();

-- 
Jani Nikula, Intel