Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <swati2.sharma@intel.com>, <karthik.b.s@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_display_modes: Skip test if big joiner display is connected
Date: Wed, 30 Oct 2024 08:14:51 +0530	[thread overview]
Message-ID: <2c2ac067-6070-41b7-88fd-e187d4d89eac@intel.com> (raw)
In-Reply-To: <20241029092445.1965070-1-jeevan.b@intel.com>



On 29-10-2024 14:54, Jeevan B wrote:
> High-resolution displays that support big joiner can cause extended mode
> tests to fail. This commit introduces a check to skip these tests if a
> big joiner display is connected, ensuring the test suite runs smoothly
> without unnecessary failures.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index f1d8ab03d..0950cc483 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -318,6 +318,12 @@ igt_main
>   		igt_display_require_output(&data.display);
>   
>   		for_each_connected_output(&data.display, output) {
> +			drmModeConnector *connector = output->config.connector;
> +			drmModeModeInfo mode;
> +			int max_dotclock = igt_get_max_dotclock(data.drm_fd);
> +
> +			igt_require_f(!bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode),
> +				      "Big Joiner Connector Found Unsupported Config\n");
 >> Hi Jeevan,
	Do we need to skip ultra joiner outputs as well here?
>   			data.mst_output[count++] = output;
>   			if (output_is_dp_mst(&data, output, dp_mst_outputs))
>   				dp_mst_outputs++;


  parent reply	other threads:[~2024-10-30  2:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29  9:24 [PATCH i-g-t] tests/kms_display_modes: Skip test if big joiner display is connected Jeevan B
2024-10-29 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-29 18:26 ` ✓ CI.xeBAT: " Patchwork
2024-10-29 21:58 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-30  2:44 ` Reddy Guddati, Santhosh [this message]
2024-10-30 15:50 ` ✗ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-11-14 18:16 [PATCH i-g-t] " Jeevan B
2024-11-15  6:21 ` Sharma, Swati2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c2ac067-6070-41b7-88fd-e187d4d89eac@intel.com \
    --to=santhosh.reddy.guddati@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox