Re: [igt-dev] [i-g-t] tests/kms_plane_alpha_blend: Align width to 256B

["Sharma, Swati2" <swati2.sharma@intel.com>]

Reviewed-by:
Swati Sharma <swati2.sharma@intel.com>

On 28-Jul-21 10:25 AM, Tejas Upadhyay wrote:
> some display resolutions like 1366x768 6bpc which does not
> have 64B aligned width are creating crc mismatch in
> kms_plane_alpha_blend test on Intel platforms.
> 
> Also having different alignment requirement by different drivers,
> 256B aligned width should work for all drm drivers.
> 
> amdgpu and radeon, amdgpu_align_pitch: 256B
> armada, armada_pitch: 128B
> exynos_drm_gem_dumb_create: No alignment required
> drm_gem_shmem_dumb_create: 8B
> drm_gem_vram_fill_create_dumb: 8B
> 
> Thus 256B covers everything we see in the kernel drm drivers.
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index d649a09f..864e83f9 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -168,6 +168,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
>   	w = mode->hdisplay;
>   	h = mode->vdisplay;
>   
> +	w = ALIGN(w, 256);
>   	/* recreate all fbs if incompatible */
>   	if (data->xrgb_fb.width != w || data->xrgb_fb.height != h) {
>   		cairo_t *cr;
> 

-- 
~Swati Sharma
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev