Re: [PATCH i-g-t v5 2/4] tests/kms_flip: run suspend tests on one pipe per output

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]


On 13-02-2026 02:19 pm, Michał Grzelak wrote:
> It is not necessary to test suspend on same output but different pipe.
> In case of suspend tests, limit number of dynamic subtests run per
> output when any pipe has already been tested.
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>

LGTM.

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>


> ---
>   tests/kms_flip.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 8bda82627..d09813f02 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1844,6 +1844,10 @@ static void run_test(int duration, int flags)
>   			    n != 0 && n != (resources->count_crtcs - 1))
>   				continue;
>   
> +			/* Limit the execution to 1 CRTC (first) for suspend tests */
> +			if ((flags & TEST_SUSPEND) && !all_crtcs && n != 0)
> +				continue;
> +
>   			memset(&o, 0, sizeof(o));
>   			o.count = 1;
>   			o._connector[0] = resources->connectors[i];
> @@ -1876,6 +1880,10 @@ static void run_test(int duration, int flags)
>   			    n != 0 && n != (resources->count_crtcs - 1))
>   				continue;
>   
> +			/* Limit the execution to 1 CRTC (first) for suspend tests */
> +			if ((flags & TEST_SUSPEND) && !all_crtcs && n != 0)
> +				continue;
> +
>   			memset(&o, 0, sizeof(o));
>   			o.count = 1;
>   			o._connector[0] = resources->connectors[i];

[-- Attachment #2: Type: text/html, Size: 37328 bytes --]