Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Hersen Wu <hersenxs.wu@amd.com>,
	igt-dev@lists.freedesktop.org, aurabindo.pillai@amd.com,
	alex.hung@amd.com, hamza.mahfooz@amd.com
Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume
Date: Mon, 24 Apr 2023 10:49:49 -0600	[thread overview]
Message-ID: <2e34a61e-4006-1cf7-fd4c-7578413a2e14@amd.com> (raw)
In-Reply-To: <20230424134845.67398-1-hersenxs.wu@amd.com>



On 4/24/23 07:48, Hersen Wu wrote:
> at call back of igt_system_suspend_autoresume, linux kernel resume
> finish and in d0 state. but user mode components may not be fully
> out of sleep mode. add delay wait for system stable before issuing
> debugfs_hotplug_trigger.
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
>   tests/amdgpu/amd_hotplug.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/amdgpu/amd_hotplug.c b/tests/amdgpu/amd_hotplug.c
> index 736040a2..1c946ff8 100644
> --- a/tests/amdgpu/amd_hotplug.c
> +++ b/tests/amdgpu/amd_hotplug.c
> @@ -133,6 +133,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
>   	if (suspend) {
>   		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
>   					      SUSPEND_TEST_NONE);
> +		sleep(30);

Do we need to wait all of this time? If so, why?

>   	}
>   
>   	/* Trigger hotplug and confirm reference image is the same. */

  parent reply	other threads:[~2023-04-24 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 13:48 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume Hersen Wu
2023-04-24 16:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-04-24 16:49 ` Rodrigo Siqueira Jordao [this message]
2023-04-24 19:02   ` [igt-dev] [PATCH] [i-g-t] " Wu, Hersen
2023-04-24 19:15     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e34a61e-4006-1cf7-fd4c-7578413a2e14@amd.com \
    --to=rodrigo.siqueira@amd.com \
    --cc=alex.hung@amd.com \
    --cc=aurabindo.pillai@amd.com \
    --cc=hamza.mahfooz@amd.com \
    --cc=hersenxs.wu@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox