From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
References: <20180423095238.29238-1-tvrtko.ursulin@linux.intel.com>
 <20180423095238.29238-4-tvrtko.ursulin@linux.intel.com>
From: John Harrison <John.C.Harrison@Intel.com>
Message-ID: <2eb5dddf-9bdf-5b47-19e8-568c8bad3cf2@Intel.com>
Date: Mon, 7 May 2018 16:58:47 -0700
MIME-Version: 1.0
In-Reply-To: <20180423095238.29238-4-tvrtko.ursulin@linux.intel.com>
Content-Language: en-US
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] trace.pl: Fix incomplete request
 handling
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

T24gNC8yMy8yMDE4IDI6NTIgQU0sIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRr
byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBJbmNvbXBsZXRlIHJlcXVl
c3RzIChubyBub3RpZnksIG5vIGNvbnRleHQgY29tcGxldGUpIGhhdmUgdG8gYmUgY29ycmVjdGVk
Cj4gYnkgbG9va2luZyBhdCB0aGUgZW5naW5lIHRpbWVsaW5lLCBhbmQgbm90IHRoZSBzb3J0ZWQt
Ynktc3RhcnQtdGltZSB2aWV3Cj4gYXMgd2FzIHByZXZpb3VzbHkgdXNlZC4KPgo+IFBlci1lbmdp
bmUgdGltZWxpbmVzIGFyZSBnZW5lcmF0ZWQgb24gZGVtYW5kIGFuZCBjYWNoZWQgZm9yIGxhdGVy
IHVzZS4KPgo+IHYyOiBGaW5kIGVuZCBvZiBjdXJyZW50IGNvbnRleHQgb24gdGhlIGVuZ2luZSB0
aW1lbGluZSBpbnN0ZWFkIG9mIGp1c3QKPiAgICAgIHVzaW5nIHRoZSBuZXh0IHJlcXVlc3QgZm9y
IGFkanVzdGluZyB0aGUgaW5jb21wbGV0ZSBzdGFydCB0aW1lLgo+Cj4gU2lnbmVkLW9mZi1ieTog
VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogSm9obiBIYXJy
aXNvbiA8Sm9obi5DLkhhcnJpc29uQGludGVsLmNvbT4KPiAtLS0KPiAgIHNjcmlwdHMvdHJhY2Uu
cGwgfCA4NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t
LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDY1IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9u
cygtKQo+Cj4gZGlmZiAtLWdpdCBhL3NjcmlwdHMvdHJhY2UucGwgYi9zY3JpcHRzL3RyYWNlLnBs
Cj4gaW5kZXggZWI1YTM2YjkxYTVjLi5iNDhmNDMyMjVmYzEgMTAwNzU1Cj4gLS0tIGEvc2NyaXB0
cy90cmFjZS5wbAo+ICsrKyBiL3NjcmlwdHMvdHJhY2UucGwKPiBAQCAtMjYsNiArMjYsOCBAQCB1
c2Ugc3RyaWN0Owo+ICAgdXNlIHdhcm5pbmdzOwo+ICAgdXNlIDUuMDEwOwo+ICAgCj4gK3VzZSBM
aXN0OjpVdGlsOwo+ICsKPiAgIG15ICRnaWQgPSAwOwo+ICAgbXkgKCVkYiwgJXF1ZXVlLCAlc3Vi
bWl0LCAlbm90aWZ5LCAlcmluZ3MsICVjdHhkYiwgJXJpbmdtYXAsICVyZXF3YWl0KTsKPiAgIG15
IEBmcmVxczsKPiBAQCAtNTE2LDI5ICs1MTgsNzEgQEAgZm9yZWFjaCBteSAka2V5IChrZXlzICVk
Yikgewo+ICAgCX0KPiAgIH0KPiAgIAo+IC0jIEZpeCB1cCBpbmNvbXBsZXRlcwo+ICAgbXkgJGtl
eV9jb3VudCA9IHNjYWxhcihrZXlzICVkYik7Cj4gLWZvcmVhY2ggbXkgJGtleSAoa2V5cyAlZGIp
IHsKPiAtCW5leHQgdW5sZXNzIGV4aXN0cyAkZGJ7JGtleX0tPnsnaW5jb21wbGV0ZSd9Owo+ICAg
Cj4gLQkjIEVuZCB0aGUgaW5jb21wbGV0ZSBiYXRjaCBhdCB0aGUgdGltZSBuZXh0IG9uZSBzdGFy
dHMKPiAtCW15ICRyaW5nID0gJGRieyRrZXl9LT57J3JpbmcnfTsKPiAtCW15ICRjdHggPSAkZGJ7
JGtleX0tPnsnY3R4J307Cj4gLQlteSAkc2Vxbm8gPSAkZGJ7JGtleX0tPnsnc2Vxbm8nfTsKPiAt
CW15ICRuZXh0X2tleTsKPiAtCW15ICRpID0gMTsKPiArbXkgJWVuZ2luZV90aW1lbGluZXM7Cj4g
Kwo+ICtzdWIgc29ydEVuZ2luZSB7Cj4gKwlteSAkYXMgPSAkZGJ7JGF9LT57J2dsb2JhbCd9Owo+
ICsJbXkgJGJzID0gJGRieyRifS0+eydnbG9iYWwnfTsKPiArCW15ICR2YWw7Cj4gKwo+ICsJJHZh
bCA9ICRhcyA8PT4gJGJzOwo+ICsKPiArCWRpZSBpZiAkdmFsID09IDA7Cj4gKwo+ICsJcmV0dXJu
ICR2YWw7Cj4gK30KPiArCj4gK3N1YiBnZXRfZW5naW5lX3RpbWVsaW5lIHsKPiArCW15ICgkcmlu
ZykgPSBAXzsKPiArCW15IEB0aW1lbGluZTsKPiArCj4gKwlyZXR1cm4gJGVuZ2luZV90aW1lbGlu
ZXN7JHJpbmd9IGlmIGV4aXN0cyAkZW5naW5lX3RpbWVsaW5lc3skcmluZ307Cj4gKwo+ICsJQHRp
bWVsaW5lID0gZ3JlcCB7ICRkYnskX30tPnsncmluZyd9ID09ICRyaW5nIH0ga2V5cyAlZGI7Cj4g
KwkjIEZJWE1FIHNlcW5vIHJlc3RhcnQKPiArCUB0aW1lbGluZSA9IHNvcnQgc29ydEVuZ2luZSBA
dGltZWxpbmU7Cj4gKwo+ICsJJGVuZ2luZV90aW1lbGluZXN7JHJpbmd9ID0gXEB0aW1lbGluZTsK
PiArCj4gKwlyZXR1cm4gXEB0aW1lbGluZTsKPiArfQo+ICsKPiArIyBGaXggdXAgaW5jb21wbGV0
ZXMgYnkgZW5kaW5nIHRoZW0gd2hlbiB0aGUgbGFzdCByZXF1ZXN0IG9mIGEgY29hbGVzY2VkIGdy
b3VwCj4gKyMgZW5kcy4gU3RhcnQgYnkgZmlsdGVyaW5nIG91dCB0aGUgaW5jb21wbGV0ZSByZXF1
ZXN0cy4KPiArbXkgQGluY29tcGxldGVzID0gc29ydCBncmVwIHsgZXhpc3RzICRkYnskX30tPnsn
aW5jb21wbGV0ZSd9IH0ga2V5cyAlZGI7Cj4gKwo+ICtmb3JlYWNoIG15ICRrZXkgKEBpbmNvbXBs
ZXRlcykgewo+ICsJbXkgJHRpbWVsaW5lOwo+ICsJbXkgJGxhc3Rfa2V5Owo+ICAgCW15ICRlbmQ7
Cj4gKwlteSAkaTsKPiAgIAo+IC0JZG8gewo+IC0JCSRuZXh0X2tleSA9IGRiX2tleSgkcmluZywg
JGN0eCwgJHNlcW5vICsgJGkpOwo+IC0JCSRpKys7Cj4gLQl9IHVudGlsICgoZXhpc3RzICRkYnsk
bmV4dF9rZXl9IGFuZCBub3QgZXhpc3RzICRkYnskbmV4dF9rZXl9LT57J2luY29tcGxldGUnfSkK
PiAtCQkgb3IgJGkgPiAka2V5X2NvdW50KTsgICMgdWdseSBzdG9wIGhhY2sKPiArCSMgRmluZCB0
aGUgbmV4dCByZXF1ZXN0IG9uIHRoZSBlbmdpbmUgdGltZWxpbmUuCj4gKwkkdGltZWxpbmUgPSBn
ZXRfZW5naW5lX3RpbWVsaW5lKCRkYnska2V5fS0+eydyaW5nJ30pOwo+ICsJJGkgPSBMaXN0OjpV
dGlsOjpmaXJzdCB7ICR7JHRpbWVsaW5lfVskX10gZXEgJGtleSB9IDAuLiQjeyR0aW1lbGluZX07
ClRoaXMgbGluZSBpbiBwYXJ0aWN1bGFyIG1hc3NpdmVseSBzbG93cyB0aGUgcHJvY2VzcyBkb3du
ISBXaXRoIG9uZSBvZiBteSAKbG9uZ2VyIHRyYWNlIGZpbGVzLCB0aGUgaW5jb21wbGV0ZSBmaXgt
dXAgc3RlcCB0b29rIDMwIHNlY29uZHMgcHJpb3IgdG8gCnRoaXMuIEFmdGVyIHRoaXMgcGF0Y2gs
IGl0IHRvb2sgMTEyMDUgc2Vjb25kcyEgSnVzdCBzaHkgb2YgZm91ciBob3VycyEKCkNhY2hpbmcg
dGhlIHN0YXJ0IHBvaW50IG9mIHRoZSBzZWFyY2ggZ3JlYXRseSBzcGVlZHMgdGhpbmdzIHVwIGJ1
dCBpdCBpcyAKc3RpbGwgYSBsb3Qgc2xvd2VyIHRoYW4gcHJldmlvdXMuIFdpdGggdGhlIGZvbGxv
d2luZywgaXQgaXMgZG93biB0byA0MDY4IApzZWNvbmRzLCBvciBhIGxpdHRsZSBvdmVyIG9uZSBo
b3VyLgorbXkgJGxhc3RJbmRleCA9IDA7Ci4uLgotwqDCoMKgwqDCoMKgICRpID0gTGlzdDo6VXRp
bDo6Zmlyc3QgeyAkeyR0aW1lbGluZX1bJF9dIGVxICRrZXkgfSAKMC4uJCN7JHRpbWVsaW5lfTsK
K8KgwqDCoMKgwqDCoCAkaSA9IExpc3Q6OlV0aWw6OmZpcnN0IHsgJHskdGltZWxpbmV9WyRfXSBl
cSAka2V5IH0gCiR7bGFzdEluZGV4fS4uJCN7JHRpbWVsaW5lfTsKK8KgwqDCoMKgwqDCoCBpZigg
IWRlZmluZWQoJGkpICkgeworwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAkaSA9IExpc3Q6
OlV0aWw6OmZpcnN0IHsgJHskdGltZWxpbmV9WyRfXSBlcSAka2V5IH0gCjAuLiQjeyR0aW1lbGlu
ZX07CivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRlZmluZWQoJGkpIHx8IGRpZSAiRmFp
bGVkIHRvIGZpbmQgJyRrZXknIVxuIjsKK8KgwqDCoMKgwqDCoCB9CivCoMKgwqDCoMKgwqAgJGxh
c3RJbmRleCA9ICRpOwoKSWYgSSBzb3J0IHRoZSAnQGluY29tcGxldGVzJyBhcnJheSBudW1lcmlj
YWxseSBieSBzZXFubyByYXRoZXIgdGhhbiBhcyBhIApzdHJpbmcgc29ydCwgdGhlbiBJIGdldCBy
aWQgb2YgYWxsIHRoZSBmaXJzdCBsZXZlbCBtYXRjaCBmYWlsdXJlcyAKKGV4Y2VwdCB3aGVuIHJv
bGxpbmcgZnJvbSBvbmUgcmluZyB0byB0aGUgbmV4dCkgYW5kIHRoZSB0aW1lIGRyb3BzIHRvIAox
ODE5IHNlY29uZHMgb3IgaGFsZiBhbiBob3VyLgoKK3N1YiBzb3J0S2V5cyB7CivCoMKgwqDCoMKg
wqAgbXkoICRhUiwgJGFDLCAkYVMgKSA9IHNwbGl0KCAnLycsICRhICk7CivCoMKgwqDCoMKgwqAg
bXkoICRiUiwgJGJDLCAkYlMgKSA9IHNwbGl0KCAnLycsICRiICk7CivCoMKgwqDCoMKgwqAgbXkg
JHZhbDsKKworwqDCoMKgwqDCoMKgICR2YWwgPSAkYVIgPD0+ICRiUjsKK8KgwqDCoMKgwqDCoCBy
ZXR1cm4gJHZhbCBpZiAkdmFsICE9IDA7CisKK8KgwqDCoMKgwqDCoCAkdmFsID0gJGFDIDw9PiAk
YkM7CivCoMKgwqDCoMKgwqAgcmV0dXJuICR2YWwgaWYgJHZhbCAhPSAwOworCivCoMKgwqDCoMKg
wqAgcmV0dXJuICRhUyA8PT4gJGJTOworfQorCgotbXkgQGluY29tcGxldGVzID0gc29ydCBncmVw
IHsgZXhpc3RzICRkYnskX30tPnsnaW5jb21wbGV0ZSd9IH0ga2V5cyAlZGI7CitteSBAaW5jb21w
bGV0ZXMgPSBzb3J0IHNvcnRLZXlzIGdyZXAgeyBleGlzdHMgJGRieyRffS0+eydpbmNvbXBsZXRl
J30gfSAKa2V5cyAlZGI7CgoKCj4gKwo+ICsJd2hpbGUgKCRpIDwgJCN7JHRpbWVsaW5lfSkgewo+
ICsJCW15ICRuZXh0Owo+ICsKPiArCQkkaSA9ICRpICsgMTsKJGkrKzsgPwoKPiArCQkkbmV4dCA9
ICR7JHRpbWVsaW5lfVskaV07Cj4gKwo+ICsJCW5leHQgaWYgZXhpc3RzICRkYnskbmV4dH0tPnsn
aW5jb21wbGV0ZSd9Owo+ICAgCj4gLQlpZiAoZXhpc3RzICRkYnskbmV4dF9rZXl9KSB7Cj4gLQkJ
JGVuZCA9ICRkYnskbmV4dF9rZXl9LT57J2VuZCd9Owo+ICsJCSRsYXN0X2tleSA9ICRuZXh0Owo+
ICsJCWxhc3Q7Cj4gKwl9Cj4gKwo+ICsJaWYgKGRlZmluZWQgJGxhc3Rfa2V5KSB7Cj4gKwkJaWYg
KCRkYnska2V5fS0+eydjdHgnfSBlcSAkZGJ7JGxhc3Rfa2V5fS0+eydjdHgnfSkgewo+ICsJCQkk
ZW5kID0gJGRieyRsYXN0X2tleX0tPnsnZW5kJ307Cj4gKwkJfSBlbHNlIHsKPiArCQkJJGVuZCA9
ICRkYnskbGFzdF9rZXl9LT57J3N0YXJ0J307Cj4gKwkJfQo+ICAgCX0gZWxzZSB7Cj4gLQkJIyBO
byBpbmZvIGF0IGFsbCwgZmFrZSBpdDoKPiArCQkjIE5vIG5leHQgc3VibWlzc2lvbiwgZmFrZSBp
dC4KPiAgIAkJJGVuZCA9ICRkYnska2V5fS0+eydzdGFydCd9ICsgOTk5Owo+ICAgCX0KPiAgIAo+
IEBAIC01NDYsMTAgKzU5MCw2IEBAIGZvcmVhY2ggbXkgJGtleSAoa2V5cyAlZGIpIHsKPiAgIAkk
ZGJ7JGtleX0tPnsnZW5kJ30gPSAkZW5kOwo+ICAgfQo+ICAgCj4gLSMgR1BVIHRpbWUgYWNjb3Vu
dGluZwo+IC1teSAoJXJ1bm5pbmcsICVydW5uYWJsZSwgJXF1ZXVlZCwgJWJhdGNoX2F2ZywgJWJh
dGNoX3RvdGFsX2F2ZywgJWJhdGNoX2NvdW50KTsKPiAtbXkgKCVzdWJtaXRfYXZnLCAlZXhlY3V0
ZV9hdmcsICVjdHhzYXZlX2F2Zyk7Cj4gLQo+ICAgc3ViIHNvcnRTdGFydCB7Cj4gICAJbXkgJGFz
ID0gJGRieyRhfS0+eydzdGFydCd9Owo+ICAgCW15ICRicyA9ICRkYnskYn0tPnsnc3RhcnQnfTsK
PiBAQCAtNTk3LDYgKzYzNywxMCBAQCBmb3JlYWNoIG15ICRrZXkgKEBzb3J0ZWRfa2V5cykgewo+
ICAgCj4gICBAc29ydGVkX2tleXMgPSBzb3J0IHNvcnRTdGFydCBrZXlzICVkYiBpZiAkcmVfc29y
dDsKPiAgIAo+ICsjIEdQVSB0aW1lIGFjY291bnRpbmcKPiArbXkgKCVydW5uaW5nLCAlcnVubmFi
bGUsICVxdWV1ZWQsICViYXRjaF9hdmcsICViYXRjaF90b3RhbF9hdmcsICViYXRjaF9jb3VudCk7
Cj4gK215ICglc3VibWl0X2F2ZywgJWV4ZWN1dGVfYXZnLCAlY3R4c2F2ZV9hdmcpOwo+ICsKClRo
aXMgaXMganVzdCBhIHByZXR0aWZpY2F0aW9uIHR5cGUgY2hhbmdlPyBNb3ZpbmcgZGVjbGFyYXRp
b25zIHRvIGJlIAptb3JlIGxvY2FsIHRvIHRoZWlyIHVzYWdlPyBJdCBkb2Vzbid0IHNlZW0gdG8g
YmUgcmVsYXRlZCB0byB0aGUgYWJvdmUgCmNoYW5nZXMgb3IgZXhwbGljaXRseSBtZW50aW9uZWQg
aW4gdGhlIGNvbW1pdCBtZXNzYWdlLgoKPiAgIG15ICRsYXN0X3RzID0gMDsKPiAgIG15ICRmaXJz
dF90czsKPiAgIG15ICgkbWluX2N0eCwgJG1heF9jdHgpOwoKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pZ3QtZGV2Cg==