Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[Antonio Argenziano <antonio.argenziano@intel.com>]

On 30/01/20 21:18, Dixit, Ashutosh wrote:
> On Thu, 30 Jan 2020 16:39:15 -0800, Antonio Argenziano wrote:
>>
>> The gtt tests try to verify that a gtt mapped area can be used as an
>> sseu pointer so it wouldn't make sense to run those when gtt mapping is
>> not available.
>>
>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>> ---
>>   tests/i915/gem_ctx_sseu.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
>> index 38dc584b..8b014b30 100644
>> --- a/tests/i915/gem_ctx_sseu.c
>> +++ b/tests/i915/gem_ctx_sseu.c
>> @@ -374,6 +374,8 @@ test_ggtt_args(int fd)
>> 	};
>> 	uint32_t bo;
>>
>> +	gem_require_mappable_ggtt(fd);
>> +
>> 	bo = gem_create(fd, 4096);
>> 	arg.value = to_user_pointer(gem_mmap__gtt(fd, bo, 4096,
>> 						  PROT_READ | PROT_WRITE));
>> --
>> 2.21.0
> 
> Assuming no issues of memory leaks here:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> 
> Otherwise this is better?

No strong preference for me.

Antonio

> 
> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
> index 38dc584bc..2add20c97 100644
> --- a/tests/i915/gem_ctx_sseu.c
> +++ b/tests/i915/gem_ctx_sseu.c
> @@ -528,8 +528,10 @@ igt_main
>                  igt_subtest("invalid-sseu")
>                          test_invalid_sseu(fd);
> 
> -               igt_subtest("ggtt-args")
> +               igt_subtest("ggtt-args") {
> +                       gem_require_mappable_ggtt(fd);
>                          test_ggtt_args(fd);
> +               }
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev