Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Avoid using borked engines

From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Avoid using borked engines
Date: Wed, 31 Jul 2019 11:31:38 -0700	[thread overview]
Message-ID: <2ebddb86-a072-45f7-b64c-26e296d3ba0e@intel.com> (raw)
In-Reply-To: <20190729191955.24544-1-chris@chris-wilson.co.uk>

On 07/29/2019 12:19 PM, Chris Wilson wrote:
> Check for viability of store-dword before use.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_exec_schedule.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 4ccacba41..6e8466299 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -282,9 +282,11 @@ static void smoketest(int fd, unsigned ring, unsigned timeout)
>   	nengine = 0;
>   	if (ring == ALL_ENGINES) {
>   		for_each_physical_engine(fd, engine)
> -			engines[nengine++] = engine;
> +			if (gem_can_store_dword(fd, engine))
> +				engines[nengine++] = engine;
>   	} else {

The gem_can_store_dword() check is already executed in the fixture for 
per engine smoketest, right?
We only need it for the smoketest-all case?

Thanks,
Vinay.

> -		engines[nengine++] = ring;
> +		if (gem_can_store_dword(fd, ring))
> +			engines[nengine++] = ring;
>   	}
>   	igt_require(nengine);
>   

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev