public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ser, Simon" <simon.ser@intel.com>
To: "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v3] build: rename Meson options
Date: Mon, 15 Jul 2019 08:50:52 +0000	[thread overview]
Message-ID: <2fa6024b63f6c9e0fd59bd3ee18568cfc145b996.camel@intel.com> (raw)
In-Reply-To: <20190715085004.b25d42424nbxa3uk@ahiler-desk1.fi.intel.com>

On Mon, 2019-07-15 at 11:50 +0300, Arkadiusz Hiler wrote:
> On Fri, Jul 12, 2019 at 04:36:57PM +0300, Simon Ser wrote:
> > Meson emits a warning because we use options beginning with "build_":
> > 
> >     DEPRECATION: Option uses prefix "build_", which is reserved for Meson. This will become an error in the future.
> > 
> > Rename our options so that we don't use the Meson-reserved prefix.
> > 
> > v2: dropped "While at it, also make other build descriptions more consistent"
> > 
> > v3: updated .gitlab-ci.yml
> > 
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> 
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> I just hope that people who will be packging this look at meson
> warnings...

Maybe this is something we can add to the release notes?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-07-15  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 13:36 [igt-dev] [PATCH i-g-t v3] build: rename Meson options Simon Ser
2019-07-12 14:57 ` [igt-dev] ✓ Fi.CI.BAT: success for build: rename Meson options (rev3) Patchwork
2019-07-12 17:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2019-07-15  7:52   ` Ser, Simon
2019-07-14  3:26 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2019-07-15  8:50 ` [igt-dev] [PATCH i-g-t v3] build: rename Meson options Arkadiusz Hiler
2019-07-15  8:50   ` Ser, Simon [this message]
2019-07-15  8:54     ` Arkadiusz Hiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fa6024b63f6c9e0fd59bd3ee18568cfc145b996.camel@intel.com \
    --to=simon.ser@intel.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox