Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Riana Tauro <riana.tauro@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
	<intel-gfx@lists.freedesktop.org>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3
Date: Thu, 31 Aug 2023 17:39:33 +0530	[thread overview]
Message-ID: <300de67d-dba0-d753-2c86-df51026a6497@intel.com> (raw)
In-Reply-To: <20230830233836.477940-1-vinay.belgaumkar@intel.com>



On 8/31/2023 5:08 AM, Vinay Belgaumkar wrote:
> Test skips whenever S3 is not supported, use s2idle instead, which is
> widely enabled.
> 
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   tests/i915/i915_pm_freq_api.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c
> index 2912287c4..03bd0d05b 100644
> --- a/tests/i915/i915_pm_freq_api.c
> +++ b/tests/i915/i915_pm_freq_api.c
> @@ -125,7 +125,7 @@ static void test_suspend(int i915, int dirfd, int gt)
>   		igt_assert_eq(req_freq, rpn);
>   
>   	/* Manually trigger a suspend */
> -	igt_system_suspend_autoresume(SUSPEND_STATE_S3,
> +	igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE,
>   				      SUSPEND_TEST_NONE);
>   
>   	req_freq = get_freq(dirfd, RPS_CUR_FREQ_MHZ);

  parent reply	other threads:[~2023-08-31 12:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 23:38 [igt-dev] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3 Vinay Belgaumkar
2023-08-31  1:07 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-08-31  1:57 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-08-31  7:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-31 12:09 ` Riana Tauro [this message]
2023-08-31 15:46 ` [igt-dev] [PATCH i-g-t] " Gupta, Anshuman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=300de67d-dba0-d753-2c86-df51026a6497@intel.com \
    --to=riana.tauro@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox