Re: [PATCH i-g-t] scripts/test_list: Do not stop the build process in the case of test documantion problem

[Karthik B S <karthik.b.s@intel.com>]

Hi Kamil,

Thank you for the review.

On 3/17/2025 10:31 PM, Kamil Konieczny wrote:
> Hi Karthik,
> On 2025-03-15 at 09:38:05 +0530, Karthik B S wrote:
>
> please make subject shorter, like:
>
> [PATCH i-g-t] scripts/test_list: Do not stop the build if documentation fails
Sure will make this update.
>
>> Current approach stops whole build process on a case that there is mistake
>> on documentation. Let's have entry on logs instead and continue.
>>
>> Small fix also related multiline data e.g. on Description part.
>>
>> Signed-off-by: Jari Tahvanainen <jari.tahvanainen@intel.com>
>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>> ---
>>   scripts/test_list.py | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/test_list.py b/scripts/test_list.py
>> index 867d28400..93a35ca71 100644
>> --- a/scripts/test_list.py
>> +++ b/scripts/test_list.py
>> @@ -1399,7 +1399,7 @@ class TestList:
>>   
>>                   # Handle multi-line field contents
>>                   if current_field:
>> -                    match = re.match(r'\s+(.*)', file_line)
>> +                    match = re.match(r'(.*)', file_line)
>>                       if match:
>>                           if handle_section == 'test':
>>                               dic = self.doc[current_test]
>> @@ -1408,7 +1408,7 @@ class TestList:
>>   
>>                           if dic[current_field] != '':
>>                               dic[current_field] += " "
>> -                        dic[current_field] += match.group(1)
>> +                        dic[current_field] += match.group(1).strip()
>>                           continue
>>   
>>                   # Handle multi-line argument contents
>> @@ -1427,7 +1427,7 @@ class TestList:
>>                       continue
>>   
>>                   file_line.rstrip(r"\n")
>> -                sys.exit(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" %
>> +                printf(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" %
> As now it is not error change it to Warning:

Sure, will change this.

Thanks,
Karthik.B.S
>
> With this
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
>>                            (config_origin, file_line))
>>   
>>       def show_subtests(self, sort_field):
>> -- 
>> 2.43.0
>>