From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8689C10EB10 for ; Fri, 20 Jan 2023 19:38:30 +0000 (UTC) Message-ID: <31511fdf-76f8-5ed0-9bd2-7eecf55d689d@linux.intel.com> Date: Fri, 20 Jan 2023 20:38:25 +0100 MIME-Version: 1.0 Content-Language: en-US To: Matthew Auld , Nirmoy Das , igt-dev@lists.freedesktop.org References: <20230120100750.24122-1-nirmoy.das@intel.com> <20230120100750.24122-2-nirmoy.das@intel.com> <9b0f24fd-5a46-d695-859b-4cccfe63b6bd@intel.com> From: "Das, Nirmoy" In-Reply-To: <9b0f24fd-5a46-d695-859b-4cccfe63b6bd@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 2/2] test/i915/gem_eio: Skip suspend test on smallbar machine List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 1/20/2023 4:45 PM, Matthew Auld wrote: > On 20/01/2023 10:07, Nirmoy Das wrote: >> Suspending machine requires backing up gem objects to >> system memory. CPU non-visible lmem objects can only be >> backed up with the help of GPU on a smallbar device and if >> the gpu is wedged then such backup action will fail with -EIO. >> >> This test sets the gpu to wedge state before suspending the >> machine which will always fail on smallbar machine. >> >> References: https://gitlab.freedesktop.org/drm/intel/-/issues/7896 >> Signed-off-by: Nirmoy Das > > For the series, > Reviewed-by: Matthew Auld Thanks, Matt! Also please help merging these. > > I guess this would also fail on full-bar, if there were some userspace > lmem objects allocated during the test (due to ccs). True that can happen. Not sure if we can do anything in that case. Regards, Nirmoy > > >> --- >>   tests/i915/gem_eio.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c >> index 70e82b811..8dbaa7a75 100644 >> --- a/tests/i915/gem_eio.c >> +++ b/tests/i915/gem_eio.c >> @@ -500,6 +500,7 @@ static void test_wait(int fd, unsigned int flags, >> unsigned int wait) >>     static void test_suspend(int fd, int state) >>   { >> +    igt_require(!gem_has_smallbar(fd)); >>       /* Do a suspend first so that we don't skip inside the test */ >>       igt_system_suspend_autoresume(state, SUSPEND_TEST_DEVICES);