Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Shankar, Uma" <uma.shankar@intel.com>
To: "B, Jeevan" <jeevan.b@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively unloading snd driver
Date: Tue, 5 Oct 2021 04:59:35 +0000	[thread overview]
Message-ID: <31a014d2d2c94969bbf65db929e05269@intel.com> (raw)
In-Reply-To: <20210923064526.18615-1-jeevan.b@intel.com>



> -----Original Message-----
> From: B, Jeevan <jeevan.b@intel.com>
> Sent: Thursday, September 23, 2021 12:15 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; B, Jeevan <jeevan.b@intel.com>
> Subject: [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively
> unloading snd driver
> 
> change igt_warn to igt_info when unloading the snd module before unbinding i915
> until WA is fixed. As this "todo reminder" is flagged as BAT failure and showing up in
> all sorts of top-bugs lists for various platforms.

Seems ok to clear the BAT noise, till the proper fix is done in audio driver.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

Note: Since this is a v2, you should add this and what changed in this version.

> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/core_hotunplug.c | 2 +-
>  tests/device_reset.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index
> 2d73e27f..b3661668 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char
> *prefix,
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c index e6a468e6..982ba5ef
> 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> --
> 2.19.1

      parent reply	other threads:[~2021-10-05  4:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  6:45 [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively unloading snd driver Jeevan B
2021-09-23  7:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-10-05  4:59 ` Shankar, Uma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31a014d2d2c94969bbf65db929e05269@intel.com \
    --to=uma.shankar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox