Re: [PATCH i-g-t 2/3] lib/intel_batchbuffer: Select xe2 rendercopy for LunarLake

["Grzegorzek, Dominik" <dominik.grzegorzek@intel.com>]

On Mon, 2024-01-08 at 12:30 +0100, Zbigniew Kempczyński wrote:
> Along with rendercopy xe2 pipeline / shader selection for LunarLake
> reorganize if/else conditionals to handle specific selection first.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  lib/intel_batchbuffer.c | 38 ++++++++++++++++++++------------------
>  1 file changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index ccab55cec7..d374645d99 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -656,28 +656,30 @@ igt_render_copyfunc_t igt_get_render_copyfunc(int devid)
>  {
>  	igt_render_copyfunc_t copy = NULL;
>  
> -	if (IS_GEN2(devid))
> -		copy = gen2_render_copyfunc;
> -	else if (IS_GEN3(devid))
> -		copy = gen3_render_copyfunc;
> -	else if (IS_GEN4(devid) || IS_GEN5(devid))
> -		copy = gen4_render_copyfunc;
> -	else if (IS_GEN6(devid))
> -		copy = gen6_render_copyfunc;
> -	else if (IS_GEN7(devid))
> -		copy = gen7_render_copyfunc;
> -	else if (IS_GEN8(devid))
> -		copy = gen8_render_copyfunc;
> -	else if (IS_GEN9(devid) || IS_GEN10(devid))
> -		copy = gen9_render_copyfunc;
> -	else if (IS_GEN11(devid))
> -		copy = gen11_render_copyfunc;
> +	if (IS_METEORLAKE(devid))
> +		copy = mtl_render_copyfunc;
> +	else if (IS_LUNARLAKE(devid))
> +		copy = genxe2_render_copyfunc;
May we make it xe2_ here as well?

Reviewed-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>  	else if (HAS_FLATCCS(devid))
>  		copy = gen12p71_render_copyfunc;
> -	else if (IS_METEORLAKE(devid))
> -		copy = mtl_render_copyfunc;
>  	else if (IS_GEN12(devid))
>  		copy = gen12_render_copyfunc;
> +	else if (IS_GEN11(devid))
> +		copy = gen11_render_copyfunc;
> +	else if (IS_GEN9(devid) || IS_GEN10(devid))
> +		copy = gen9_render_copyfunc;
> +	else if (IS_GEN8(devid))
> +		copy = gen8_render_copyfunc;
> +	else if (IS_GEN7(devid))
> +		copy = gen7_render_copyfunc;
> +	else if (IS_GEN6(devid))
> +		copy = gen6_render_copyfunc;
> +	else if (IS_GEN4(devid) || IS_GEN5(devid))
> +		copy = gen4_render_copyfunc;
> +	else if (IS_GEN3(devid))
> +		copy = gen3_render_copyfunc;
> +	else if (IS_GEN2(devid))
> +		copy = gen2_render_copyfunc;
>  
>  	return copy;
>  }