From: Swati Sharma <swati2.sharma@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
igt-dev@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: add missing include in header
Date: Sat, 21 Jan 2023 10:58:28 +0530 [thread overview]
Message-ID: <324d68f2-2d9d-6b81-3d5d-73e86930a1f8@intel.com> (raw)
In-Reply-To: <20230120181243.oysvrqxat3vs7gzh@kamilkon-desk1>
Thanks for the patch Kamil!
https://patchwork.freedesktop.org/series/113170/ gitlab pipeline is
success now.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 20-Jan-23 11:42 PM, Kamil Konieczny wrote:
> Hi,
>
> On 2023-01-20 at 23:11:19 +0530, Swati Sharma wrote:
>> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>>
>> Direct include of lib igt_fb header breaks builds with errors
>>
>> xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’
>>
>> Fixed it with adding proper include in heade
>
> This one should be first in series, not last one.
I can re-float if required.
>
> Petri: there is also no [igt-dev] in subject ?
>
> Regards,
> Kamil
>
>>
>> Cc: Swati Sharma <swati2.sharma@intel.com>
>> Cc: Petri Latvala <petri.latvala@intel.com>
>> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> ---
>> lib/igt_fb.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
>> index 6995b14b..73bdfc86 100644
>> --- a/lib/igt_fb.h
>> +++ b/lib/igt_fb.h
>> @@ -32,6 +32,7 @@
>> #include <cairo.h>
>> #include <stddef.h>
>> #include <stdbool.h>
>> +#include <stdint.h>
>> #include <drm_fourcc.h>
>> #include <xf86drmMode.h>
>>
>> --
>> 2.25.1
>>
--
~Swati Sharma
next prev parent reply other threads:[~2023-01-21 5:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:41 [igt-dev] [PATCH i-g-t 0/5] tests/i915/kms_dsc: Reorg + Fix Swati Sharma
2023-01-20 17:41 ` [igt-dev] [PATCH i-g-t 1/5] lib/dsc: Move VDSC functions to separate lib file Swati Sharma
2023-01-20 17:41 ` [igt-dev] [PATCH i-g-t 2/5] Move wrapper functions from kms_dsc to kms_dsc_helper Swati Sharma
2023-01-20 17:41 ` [igt-dev] [PATCH i-g-t 3/5] tests/i915/kms_dsc: Add disp_ver as struct data_t member Swati Sharma
2023-01-20 17:41 ` [igt-dev] [PATCH i-g-t 4/5] tests/i915/kms_dsc_helper: Improve format string Swati Sharma
2023-01-20 17:41 ` [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: add missing include in header Swati Sharma
2023-01-20 18:12 ` Kamil Konieczny
2023-01-21 5:28 ` Swati Sharma [this message]
2023-01-23 10:37 ` Petri Latvala
2023-01-20 18:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_dsc: Reorg + Fix Patchwork
2023-01-21 20:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=324d68f2-2d9d-6b81-3d5d-73e86930a1f8@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox