From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 440BD10E710 for ; Wed, 6 Sep 2023 19:08:40 +0000 (UTC) Message-ID: <331035f9-0307-21dc-c19d-61708ef4a4fe@intel.com> Date: Thu, 7 Sep 2023 00:38:17 +0530 Content-Language: en-US To: Sean Paul , References: <20230825183934.1271156-1-sean@poorly.run> <20230825183934.1271156-6-sean@poorly.run> From: "Modem, Bhanuprakash" In-Reply-To: <20230825183934.1271156-6-sean@poorly.run> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH 5/6] tests/kms_vrr: Change the pattern displayed in the test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Sat-26-08-2023 12:06 am, Sean Paul wrote: > From: Sean Paul > > Upgrade the tiny box in the top left corner to some vertical color > bars with horizontal grey and white bars at the bottom. > > Cc: Mark Yacoub > Signed-off-by: Sean Paul > --- > tests/kms_vrr.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c > index 67d13d4bf..e6820a0d1 100644 > --- a/tests/kms_vrr.c > +++ b/tests/kms_vrr.c > @@ -242,6 +242,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe) > { > drmModeModeInfo mode; > cairo_t *cr; > + int bar_width; > > /* Reset output */ > igt_display_reset(&data->display); > @@ -284,11 +285,18 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe) > DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, > 0.50, 0.50, 0.50, &data->fb[1]); > > + bar_width = mode.hdisplay / 3; I can fell, it would be better to fill the full screen. ex: remaining_rows = mode.hdisplay % 3; and paint it with the last used colors (bar 3) > cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[0]); > - > - igt_paint_color(cr, 0, 0, mode.hdisplay / 10, mode.vdisplay / 10, > - 1.00, 0.00, 0.00); > - > + for (int j = 0; j < 3; ++j) { > + unsigned int color = 1 << j; > + igt_paint_color(cr, bar_width * j, 0, bar_width, > + mode.vdisplay - 200, ------------------------------------------------^ > + color >> 0 & 1, > + color >> 1 & 1, > + color >> 2 & 1); > + } > + igt_paint_color(cr, 0, mode.vdisplay - 100, mode.hdisplay, 100, -----------------------------------------------^-------------------^ Instead of using these magic numbers, can't we measure like vidsplay/4 or something like that? - Bhanu > + 1.00, 1.00, 1.00); > igt_put_cairo_ctx(cr); > > /* Take care of any required modesetting before the test begins. */