From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EFF710E7DA for ; Fri, 1 Dec 2023 10:49:56 +0000 (UTC) Message-ID: <336752e7-06ce-44d6-81dc-aec791299b0c@intel.com> Date: Fri, 1 Dec 2023 16:19:50 +0530 MIME-Version: 1.0 Content-Language: en-US To: Mohammed Thasleem , igt-dev@lists.freedesktop.org References: <20231201100725.8646-1-mohammed.thasleem@intel.com> <20231201100725.8646-3-mohammed.thasleem@intel.com> From: "Sharma, Swati2" In-Reply-To: <20231201100725.8646-3-mohammed.thasleem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH v3 2/2] tests/intel/kms_pm_dc: Add LNL platform for dc9-dpms validation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Swati Sharma On 01-Dec-23 3:37 PM, Mohammed Thasleem wrote: > DC5 counter on disp ver >=14 is not expected to get reset in DC9 state. > Add LNL patform to use runtime_suspended_time value to validate DC9 > dpms test. > > v2: Update subject and commit message. (Swati) > v3: Move lib/intel_chipset.h changes in separate patch. (Kamil) > > Cc: Swati Sharma > Signed-off-by: Mohammed Thasleem > --- > tests/intel/kms_pm_dc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c > index 8006e54de..0d5824e67 100644 > --- a/tests/intel/kms_pm_dc.c > +++ b/tests/intel/kms_pm_dc.c > @@ -88,7 +88,7 @@ > #define KMS_HELPER "/sys/module/drm_kms_helper/parameters/" > #define PACKAGE_CSTATE_PATH "pmc_core/package_cstate_show" > #define KMS_POLL_DISABLE 0 > -#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || IS_METEORLAKE(devid))) > +#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || AT_LEAST_DISPLAY(devid, 14))) > > IGT_TEST_DESCRIPTION("Tests to validate display power DC states."); > > @@ -505,7 +505,7 @@ static bool dc9_wait_entry(data_t *data, int dc_target, int prev_dc, int prev_rp > * Runtime suspended residency should increment once DC9 is achieved; > * this condition is valid for all platforms. > * However, resetting of dc5/dc6 counter to check if display engine was in DC9; > - * this condition at present can be skipped for dg1, dg2 and MTL platforms. > + * this condition at present can be skipped for dg1, dg2 and MTL+ platforms. > */ > return igt_wait((read_runtime_suspended_time(data->drm_fd) > prev_rpm) && > (!DC9_RESETS_DC_COUNTERS(data->devid) ||