Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: juha-pekka.heikkila@intel.com
Subject: Re: [igt-dev] [PATCH] tests/intel/i915_pipe_stress: Use only first pipe if Bigjoiner is used
Date: Thu, 14 Sep 2023 19:13:39 +0530	[thread overview]
Message-ID: <344efd54-9002-dce5-2ad2-b60706a6763e@intel.com> (raw)
In-Reply-To: <20230914080329.16648-1-stanislav.lisovskiy@intel.com>

Hi Stan,

On Thu-14-09-2023 01:33 pm, Stanislav Lisovskiy wrote:
> We currently are having test failures for Bigjoiner, because that
> test tries to use all pipes simultaneously, not realizing that
> if we use a Bigjoiner mode on pipe A, the adjacent pipe won't be
> available.
> For now just fix it by using only one pipe, if resolution > 3840
> is detected.
> 
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
>   tests/intel/i915_pipe_stress.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/intel/i915_pipe_stress.c b/tests/intel/i915_pipe_stress.c
> index 3cd84d027f..a050fa0117 100644
> --- a/tests/intel/i915_pipe_stress.c
> +++ b/tests/intel/i915_pipe_stress.c
> @@ -590,6 +590,12 @@ static void stress_pipes(struct data *data, struct timespec *start,
>   		igt_pipe_crc_stop(data->pipe_crc[pipe]);
>   		igt_assert_crc_equal(&crc, &crc2);
>   
> +		/*
> +		 * Do not try to use other pipes, if Bigjoiner is used
> +		 */
> +		if (data->highest_mode[pipe]->hdisplay > 3840)
> +			break;

I think, you can use "igt_check_bigjoiner_support()" to know the 
selected pipe can drive the Bigjoiner or not.

- Bhanu

> +
>   		++pipe;
>   	}
>   }

  parent reply	other threads:[~2023-09-14 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  8:03 [igt-dev] [PATCH] tests/intel/i915_pipe_stress: Use only first pipe if Bigjoiner is used Stanislav Lisovskiy
2023-09-14  8:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-09-14  9:24 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-14 10:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-14 13:43 ` Modem, Bhanuprakash [this message]
2023-09-27  9:01   ` [igt-dev] [PATCH] " Lisovskiy, Stanislav
2023-10-11 10:07     ` Modem, Bhanuprakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=344efd54-9002-dce5-2ad2-b60706a6763e@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox