Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Check for functional GEM before use

From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/pm_rpm: Check for functional GEM before use
Date: Tue, 29 Jan 2019 09:22:20 -0800	[thread overview]
Message-ID: <34c8b656-4e96-143c-79a7-5a9480071403@intel.com> (raw)
In-Reply-To: <20190127131353.1843-1-chris@chris-wilson.co.uk>

On 27/01/19 05:13, Chris Wilson wrote:
> Check the GPU (using GEM) is up an operational before submitting
> commands.

Always a good idea.
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/pm_rpm.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 7dcb5586d..be296f525 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -1220,6 +1220,8 @@ static void gem_execbuf_subtest(void)
>   	int sq_x = 5, sq_y = 10, sq_w = 15, sq_h = 20;
>   	uint32_t color;
>   
> +	igt_require_gem(drm_fd);
> +
>   	/* Create and set data while the device is active. */
>   	enable_one_screen_and_wait(&ms_data);
>   
> @@ -1308,6 +1310,8 @@ static void gem_execbuf_stress_subtest(int rounds, int wait_flags)
>   	struct drm_i915_gem_execbuffer2 execbuf = {};
>   	struct drm_i915_gem_exec_object2 objs[1] = {{}};
>   
> +	igt_require_gem(drm_fd);
> +
>   	if (wait_flags & WAIT_PC8_RES)
>   		igt_require(has_pc8);
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev