Re: [igt-dev] [PATCH i-g-t 3/5] tests/intel/kms_pm_dc: Use linear modifier to set primary plane

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On Mon-11-09-2023 08:40 pm, Sharma, Swati2 wrote:
> 
> On 11-Sep-23 8:15 PM, Modem, Bhanuprakash wrote:
>> Hi Swati,
>>
>> On Fri-08-09-2023 11:20 pm, Swati Sharma wrote:
>>> To setup primary plane, use DRM_FORMAT_MOD_LINEAR instead of
>>> I915_FORMAT_MOD_X_TILED.
>>>
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>> ---
>>>   tests/intel/kms_pm_dc.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
>>> index 895fe4b4c..b5779eaa5 100644
>>> --- a/tests/intel/kms_pm_dc.c
>>> +++ b/tests/intel/kms_pm_dc.c
>>> @@ -231,7 +231,7 @@ static void setup_primary(data_t *data)
>>>       igt_create_color_fb(data->drm_fd,
>>>                   data->mode->hdisplay, data->mode->vdisplay,
>>>                   DRM_FORMAT_XRGB8888,
>>> -                I915_FORMAT_MOD_X_TILED,
>>> +                DRM_FORMAT_MOD_LINEAR,
>>
>> Any special reason for this change?
> 
> For DC states validation, it doesn't matter with which modifier we are 
> creating fb.
> With this change we can make this test independent of x-tiling support.

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> 
>>
>> - Bhanu
>>
>>>                   1.0, 1.0, 1.0,
>>>                   &data->fb_white);
>>>       igt_plane_set_fb(primary, &data->fb_white);