Re: [PATCH i-g-t 2/3] lib: Add NVL-P support

[Shekhar Chauhan <shekhar.chauhan@intel.com>]

On 3/11/2026 11:19, himanshu.girotra@intel.com wrote:
> From: Himanshu Girotra <himanshu.girotra@intel.com>
>
> Add NVL-P device info.
>
> Signed-off-by: Himanshu Girotra <himanshu.girotra@intel.com>

LGTM,

Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

> ---
>   lib/intel_chipset.h     |  2 ++
>   lib/intel_device_info.c | 14 ++++++++++++++
>   2 files changed, 16 insertions(+)
>
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index cc2225110..5df7349df 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -94,6 +94,7 @@ struct intel_device_info {
>   	bool is_battlemage : 1;
>   	bool is_pantherlake : 1;
>   	bool is_novalake_s: 1;
> +	bool is_novalake_p : 1;
>   	bool is_crescentisland: 1;
>   
>   	const struct intel_cmds_info *cmds_info;
> @@ -213,6 +214,7 @@ void intel_check_pch(void);
>   #define IS_BATTLEMAGE(devid)	(intel_get_device_info(devid)->is_battlemage)
>   #define IS_PANTHERLAKE(devid)	(intel_get_device_info(devid)->is_pantherlake)
>   #define IS_NOVALAKE_S(devid)	(intel_get_device_info(devid)->is_novalake_s)
> +#define IS_NOVALAKE_P(devid)	(intel_get_device_info(devid)->is_novalake_p)
>   #define IS_CRESCENTISLAND(devid)	(intel_get_device_info(devid)->is_crescentisland)
>   
>   #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 89fa6788f..b44b24223 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -551,6 +551,18 @@ static const struct intel_device_info intel_novalake_s_info = {
>   	.cmds_info = &xe2_cmds_info,
>   };
>   
> +static const struct intel_device_info intel_novalake_p_info = {
> +	.graphics_ver = 35,
> +	.graphics_rel = 10,
> +	.display_ver = 35,
> +	.has_4tile = true,
> +	.has_oam = true,
> +	.has_flatccs = true,
> +	.is_novalake_p = true,
> +	.codename = "novalake_p",
> +	.cmds_info = &xe2_cmds_info,
> +};
> +
>   static const struct intel_device_info intel_crescentisland_info = {
>   	.graphics_ver = 35,
>   	.graphics_rel = 11,
> @@ -681,6 +693,8 @@ static const struct pci_id_match intel_device_match[] = {
>   
>   	INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_s_info),
>   
> +	INTEL_NVLP_IDS(INTEL_PCI_ID_INIT, &intel_novalake_p_info),
> +
>   	INTEL_CRI_IDS(INTEL_PCI_ID_INIT, &intel_crescentisland_info),
>   
>   	INTEL_PCI_ID_INIT(PCI_MATCH_ANY, &intel_generic_info),