From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3885689346 for ; Fri, 10 May 2019 06:55:40 +0000 (UTC) From: "Ser, Simon" Date: Fri, 10 May 2019 06:55:36 +0000 Message-ID: <356ab550a405d0345c754c9574a98737391209dc.camel@intel.com> References: <20190510000604.3580-1-lyude@redhat.com> In-Reply-To: <20190510000604.3580-1-lyude@redhat.com> Content-Language: en-US Content-ID: <9C2F84A4093C654ABC6DA1D871808E9F@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] runner: Use glib's regex utilities instead of POSIX ERE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "lyude@redhat.com" List-ID: T24gVGh1LCAyMDE5LTA1LTA5IGF0IDIwOjA2IC0wNDAwLCBMeXVkZSB3cm90ZToNCj4gRnJvbTog THl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4NCj4gDQo+IFBPU0lYIEVSRSwgd2hpbGUgcHJl dHR5IHN0YW5kYXJkIGlzIGFsc28gdmVyeSBvbGQgYW5kIHNldmVyZWx5IGxpbWl0ZWQuDQo+IElu IGZhY3QsIGl0J3Mgc28gbGltaXRlZCB0aGF0IEludGVsIENJJ3Mgb3duIHRlc3QgYmxhY2tsaXN0 LA0KPiB0ZXN0cy9pbnRlbC1jaS9ibGFja2xpc3QudHh0LCBkb2Vzbid0IGV2ZW4gd29yayB3aXRo IGl0IGR1ZSB0byB0aGUgbGFjaw0KPiBvZiBzdXBwb3J0IGZvciBiYWNrcmVmZXJlbmNlcy4NCj4g DQo+IFNpbmNlIHdlJ3JlIGFscmVhZHkgdXNpbmcgZ2xpYiBpbiBvdGhlciBwYXJ0cyBvZiBpZ3Qs IGxldCdzIGp1c3Qgc3RhcnQNCj4gdXNpbmcgZ2xpYidzIHJlZ3VsYXIgZXhwcmVzc2lvbiBtYXRj aGluZyBpbnN0ZWFkIG9mIHRoZSBQT1NJWCByZWdleCBBUEkuDQo+IFRoaXMgZ2l2ZXMgdXMgZnVs bCBwZXJsIGNvbXBhdGlibGUgcmVndWxhciBleHByZXNzaW9ucyBhbmQgaW4gdHVybiwgYWxzbw0K PiBnaXZlcyB1cyBweXRob24gY29tcGF0aWJsZSByZWd1bGFyIGV4cHJlc3Npb25zIHRvIG1hdGNo IHBpZ2xpdC4NCg0KU2lkZSBub3RlOiBhIG1vcmUgcG9ydGFibGUgYWx0ZXJuYXRpdmUgd291bGQg YmUgUENSRS4NCg0KPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t Pg0KPiAtLS0NCj4gIHJ1bm5lci9qb2JfbGlzdC5jICB8ICA0ICstLS0NCj4gIHJ1bm5lci9tZXNv bi5idWlsZCB8ICAyICstDQo+ICBydW5uZXIvcmVzdWx0Z2VuLmMgfCAxNSArKysrKysrKystLS0t LS0NCj4gIHJ1bm5lci9zZXR0aW5ncy5jICB8IDI2ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0t DQo+ICBydW5uZXIvc2V0dGluZ3MuaCAgfCAgNCArKy0tDQo+ICA1IGZpbGVzIGNoYW5nZWQsIDIz IGluc2VydGlvbnMoKyksIDI4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3J1bm5l ci9qb2JfbGlzdC5jIGIvcnVubmVyL2pvYl9saXN0LmMNCj4gaW5kZXggOTQxZTJlZTAuLjRhMTY3 NDJmIDEwMDY0NA0KPiAtLS0gYS9ydW5uZXIvam9iX2xpc3QuYw0KPiArKysgYi9ydW5uZXIvam9i X2xpc3QuYw0KPiBAQCAtMTcsMTAgKzE3LDggQEAgc3RhdGljIGJvb2wgbWF0Y2hlc19hbnkoY29u c3QgY2hhciAqc3RyLCBzdHJ1Y3QgcmVnZXhfbGlzdCAqbGlzdCkNCj4gIAlzaXplX3QgaTsNCj4g IA0KPiAgCWZvciAoaSA9IDA7IGkgPCBsaXN0LT5zaXplOyBpKyspIHsNCj4gLQkJaWYgKHJlZ2V4 ZWMobGlzdC0+cmVnZXhlc1tpXSwgc3RyLA0KPiAtCQkJICAgIChzaXplX3QpMCwgTlVMTCwgMCkg PT0gMCkgew0KPiArCQlpZiAoZ19yZWdleF9tYXRjaChsaXN0LT5yZWdleGVzW2ldLCBzdHIsIDAs IE5VTEwpKQ0KPiAgCQkJcmV0dXJuIHRydWU7DQo+IC0JCX0NCj4gIAl9DQo+ICANCj4gIAlyZXR1 cm4gZmFsc2U7DQo+IGRpZmYgLS1naXQgYS9ydW5uZXIvbWVzb24uYnVpbGQgYi9ydW5uZXIvbWVz b24uYnVpbGQNCj4gaW5kZXggZGU2ZTZmMWMuLjFmZmM5NWI0IDEwMDY0NA0KPiAtLS0gYS9ydW5u ZXIvbWVzb24uYnVpbGQNCj4gKysrIGIvcnVubmVyL21lc29uLmJ1aWxkDQo+IEBAIC0xNyw3ICsx Nyw3IEBAIGlmIF9idWlsZF9ydW5uZXIgYW5kIGpzb25jLmZvdW5kKCkNCj4gIA0KPiAgCXJ1bm5l cmxpYiA9IHN0YXRpY19saWJyYXJ5KCdpZ3RfcnVubmVyJywgcnVubmVybGliX3NvdXJjZXMsDQo+ ICAJCQkJICAgaW5jbHVkZV9kaXJlY3RvcmllcyA6IGluYywNCj4gLQkJCQkgICBkZXBlbmRlbmNp ZXMgOiBqc29uYykNCj4gKwkJCQkgICBkZXBlbmRlbmNpZXMgOiBbanNvbmMsIGdsaWJdKQ0KPiAg DQo+ICAJcnVubmVyID0gZXhlY3V0YWJsZSgnaWd0X3J1bm5lcicsIHJ1bm5lcl9zb3VyY2VzLA0K PiAgCQkJICAgIGxpbmtfd2l0aCA6IHJ1bm5lcmxpYiwNCj4gZGlmZiAtLWdpdCBhL3J1bm5lci9y ZXN1bHRnZW4uYyBiL3J1bm5lci9yZXN1bHRnZW4uYw0KPiBpbmRleCBkOTcwMmExOS4uMmI3ZDI2 ZDUgMTAwNjQ0DQo+IC0tLSBhL3J1bm5lci9yZXN1bHRnZW4uYw0KPiArKysgYi9ydW5uZXIvcmVz dWx0Z2VuLmMNCj4gQEAgLTQ5OSwxNCArNDk5LDE3IEBAIHN0YXRpYyBjb25zdCBjaGFyIGlndF9k bWVzZ193aGl0ZWxpc3RbXSA9DQo+ICBzdGF0aWMgY29uc3QgY2hhciBpZ3RfcGlnbGl0X3N0eWxl X2RtZXNnX2JsYWNrbGlzdFtdID0NCj4gIAkiKFxcW2RybTp8ZHJtX3xpbnRlbF98aTkxNV8pIjsN Cj4gIA0KPiAtc3RhdGljIGJvb2wgaW5pdF9yZWdleF93aGl0ZWxpc3Qoc3RydWN0IHNldHRpbmdz KiBzZXR0aW5ncywgcmVnZXhfdCogcmUpDQo+ICtzdGF0aWMgYm9vbCBpbml0X3JlZ2V4X3doaXRl bGlzdChzdHJ1Y3Qgc2V0dGluZ3MqIHNldHRpbmdzLCBHUmVnZXggKipyZSkNCj4gIHsNCj4gKwlH RXJyb3IgKmVyciA9IE5VTEw7DQo+ICAJY29uc3QgY2hhciAqcmVnZXggPSBzZXR0aW5ncy0+cGln bGl0X3N0eWxlX2RtZXNnID8NCj4gIAkJaWd0X3BpZ2xpdF9zdHlsZV9kbWVzZ19ibGFja2xpc3Qg Og0KPiAgCQlpZ3RfZG1lc2dfd2hpdGVsaXN0Ow0KPiAgDQo+IC0JaWYgKHJlZ2NvbXAocmUsIHJl Z2V4LCBSRUdfRVhURU5ERUQgfCBSRUdfTk9TVUIpICE9IDApIHsNCj4gKwkqcmUgPSBnX3JlZ2V4 X25ldyhyZWdleCwgR19SRUdFWF9PUFRJTUlaRSwgMCwgJmVycik7DQo+ICsJaWYgKGVycikgew0K PiAgCQlmcHJpbnRmKHN0ZGVyciwgIkNhbm5vdCBjb21waWxlIGRtZXNnIHJlZ2V4cFxuIik7DQo+ ICsJCWdfZXJyb3JfZnJlZShlcnIpOw0KPiAgCQlyZXR1cm4gZmFsc2U7DQo+ICAJfQ0KPiAgDQo+ IEBAIC02MzAsNyArNjMzLDcgQEAgc3RhdGljIGJvb2wgZmlsbF9mcm9tX2RtZXNnKGludCBmZCwN Cj4gIAljaGFyIHBpZ2xpdF9uYW1lWzI1Nl07DQo+ICAJc3NpemVfdCByZWFkOw0KPiAgCXNpemVf dCBpOw0KPiAtCXJlZ2V4X3QgcmU7DQo+ICsJR1JlZ2V4ICpyZTsNCj4gIA0KPiAgCWlmICghZikg ew0KPiAgCQlyZXR1cm4gZmFsc2U7DQo+IEBAIC02NzEsMTIgKzY3NCwxMiBAQCBzdGF0aWMgYm9v bCBmaWxsX2Zyb21fZG1lc2coaW50IGZkLA0KPiAgDQo+ICAJCWlmIChzZXR0aW5ncy0+cGlnbGl0 X3N0eWxlX2RtZXNnKSB7DQo+ICAJCQlpZiAoKGZsYWdzICYgMHgwNykgPD0gc2V0dGluZ3MtPmRt ZXNnX3dhcm5fbGV2ZWwgJiYgY29udGludWF0aW9uICE9ICdjJyAmJg0KPiAtCQkJICAgIHJlZ2V4 ZWMoJnJlLCBtZXNzYWdlLCAoc2l6ZV90KTAsIE5VTEwsIDApICE9IFJFR19OT01BVENIKSB7DQo+ ICsJCQkgICAgZ19yZWdleF9tYXRjaChyZSwgbWVzc2FnZSwgMCwgTlVMTCkpIHsNCj4gIAkJCQlh cHBlbmRfbGluZSgmd2FybmluZ3MsICZ3YXJuaW5nc2xlbiwgZm9ybWF0dGVkKTsNCj4gIAkJCX0N Cj4gIAkJfSBlbHNlIHsNCj4gIAkJCWlmICgoZmxhZ3MgJiAweDA3KSA8PSBzZXR0aW5ncy0+ZG1l c2dfd2Fybl9sZXZlbCAmJiBjb250aW51YXRpb24gIT0gJ2MnICYmDQo+IC0JCQkgICAgcmVnZXhl YygmcmUsIG1lc3NhZ2UsIChzaXplX3QpMCwgTlVMTCwgMCkgPT0gUkVHX05PTUFUQ0gpIHsNCj4g KwkJCSAgICAhZ19yZWdleF9tYXRjaChyZSwgbWVzc2FnZSwgMCwgTlVMTCkpIHsNCj4gIAkJCQlh cHBlbmRfbGluZSgmd2FybmluZ3MsICZ3YXJuaW5nc2xlbiwgZm9ybWF0dGVkKTsNCj4gIAkJCX0N Cj4gIAkJfQ0KPiBAQCAtNzE1LDcgKzcxOCw3IEBAIHN0YXRpYyBib29sIGZpbGxfZnJvbV9kbWVz ZyhpbnQgZmQsDQo+ICANCj4gIAlmcmVlKGRtZXNnKTsNCj4gIAlmcmVlKHdhcm5pbmdzKTsNCj4g LQlyZWdmcmVlKCZyZSk7DQo+ICsJZ19yZWdleF91bnJlZihyZSk7DQo+ICAJZmNsb3NlKGYpOw0K PiAgCXJldHVybiB0cnVlOw0KPiAgfQ0KPiBkaWZmIC0tZ2l0IGEvcnVubmVyL3NldHRpbmdzLmMg Yi9ydW5uZXIvc2V0dGluZ3MuYw0KPiBpbmRleCAyNWJjZjUzMS4uYWQzOGFlOGQgMTAwNjQ0DQo+ IC0tLSBhL3J1bm5lci9zZXR0aW5ncy5jDQo+ICsrKyBiL3J1bm5lci9zZXR0aW5ncy5jDQo+IEBA IC0xODcsMjMgKzE4NywxOCBAQCBzdGF0aWMgdm9pZCB1c2FnZShjb25zdCBjaGFyICpleHRyYV9t ZXNzYWdlLCBGSUxFICpmKQ0KPiAgDQo+ICBzdGF0aWMgYm9vbCBhZGRfcmVnZXgoc3RydWN0IHJl Z2V4X2xpc3QgKmxpc3QsIGNoYXIgKm5ldykNCj4gIHsNCj4gLQlyZWdleF90ICpyZWdleDsNCj4g LQlzaXplX3QgYnVmbGVuOw0KPiAtCWNoYXIgKmJ1ZjsNCj4gLQlpbnQgczsNCj4gLQ0KPiAtCXJl Z2V4ID0gbWFsbG9jKHNpemVvZigqcmVnZXgpKTsNCj4gLQ0KPiAtCWlmICgocyA9IHJlZ2NvbXAo cmVnZXgsIG5ldywNCj4gLQkJCSBSRUdfRVhURU5ERUQgfCBSRUdfTk9TVUIpKSAhPSAwKSB7DQo+ IC0JCWJ1ZmxlbiA9IHJlZ2Vycm9yKHMsIHJlZ2V4LCBOVUxMLCAwKTsNCj4gLQkJYnVmID0gbWFs bG9jKGJ1Zmxlbik7DQo+IC0JCXJlZ2Vycm9yKHMsIHJlZ2V4LCBidWYsIGJ1Zmxlbik7DQo+ICsJ R1JlZ2V4ICpyZWdleDsNCj4gKwlHRXJyb3IgKmVycm9yID0gTlVMTDsNCj4gKw0KPiArCXJlZ2V4 ID0gZ19yZWdleF9uZXcobmV3LCBHX1JFR0VYX09QVElNSVpFLCAwLCAmZXJyb3IpOw0KPiArCWlm IChlcnJvcikgew0KPiArCQljaGFyICpidWYgPSBtYWxsb2Moc25wcmludGYoTlVMTCwgMCwgIklu dmFsaWQgcmVnZXggJyVzJzogJXMiLCBuZXcsIGVycm9yLT5tZXNzYWdlKSArIDEpOw0KPiArDQo+ ICsJCXNwcmludGYoYnVmLCAiSW52YWxpZCByZWdleCAnJXMnOiAlcyIsIG5ldywgZXJyb3ItPm1l c3NhZ2UpOw0KPiAgCQl1c2FnZShidWYsIHN0ZGVycik7DQo+ICANCj4gIAkJZnJlZShidWYpOw0K PiAtCQlyZWdmcmVlKHJlZ2V4KTsNCj4gLQkJZnJlZShyZWdleCk7DQo+ICsJCWdfZXJyb3JfZnJl ZShlcnJvcik7DQo+ICAJCXJldHVybiBmYWxzZTsNCj4gIAl9DQo+ICANCj4gQEAgLTIyNCw4ICsy MTksNyBAQCBzdGF0aWMgdm9pZCBmcmVlX3JlZ2V4ZXMoc3RydWN0IHJlZ2V4X2xpc3QgKnJlZ2V4 ZXMpDQo+ICANCj4gIAlmb3IgKGkgPSAwOyBpIDwgcmVnZXhlcy0+c2l6ZTsgaSsrKSB7DQo+ICAJ CWZyZWUocmVnZXhlcy0+cmVnZXhfc3RyaW5nc1tpXSk7DQo+IC0JCXJlZ2ZyZWUocmVnZXhlcy0+ cmVnZXhlc1tpXSk7DQo+IC0JCWZyZWUocmVnZXhlcy0+cmVnZXhlc1tpXSk7DQo+ICsJCWdfcmVn ZXhfdW5yZWYocmVnZXhlcy0+cmVnZXhlc1tpXSk7DQo+ICAJfQ0KPiAgCWZyZWUocmVnZXhlcy0+ cmVnZXhfc3RyaW5ncyk7DQo+ICAJZnJlZShyZWdleGVzLT5yZWdleGVzKTsNCj4gZGlmZiAtLWdp dCBhL3J1bm5lci9zZXR0aW5ncy5oIGIvcnVubmVyL3NldHRpbmdzLmgNCj4gaW5kZXggNjcyYTNh ZjguLjBhMWVlMDhkIDEwMDY0NA0KPiAtLS0gYS9ydW5uZXIvc2V0dGluZ3MuaA0KPiArKysgYi9y dW5uZXIvc2V0dGluZ3MuaA0KPiBAQCAtNCw4ICs0LDggQEANCj4gICNpbmNsdWRlIDxzdGRib29s Lmg+DQo+ICAjaW5jbHVkZSA8c3RkZGVmLmg+DQo+ICAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+DQo+ IC0jaW5jbHVkZSA8cmVnZXguaD4NCj4gICNpbmNsdWRlIDxzdGRpby5oPg0KPiArI2luY2x1ZGUg PGdsaWIuaD4NCj4gIA0KPiAgZW51bSB7DQo+ICAJTE9HX0xFVkVMX05PUk1BTCA9IDAsDQo+IEBA IC0yMSw3ICsyMSw3IEBAIF9TdGF0aWNfYXNzZXJ0KEFCT1JUX0FMTCA9PSAoQUJPUlRfVEFJTlQg fCBBQk9SVF9MT0NLREVQKSwgIkFCT1JUX0FMTCBtdXN0IGJlIGFsDQo+ICANCj4gIHN0cnVjdCBy ZWdleF9saXN0IHsNCj4gIAljaGFyICoqcmVnZXhfc3RyaW5nczsNCj4gLQlyZWdleF90KiogcmVn ZXhlczsNCj4gKwlHUmVnZXggKipyZWdleGVzOw0KPiAgCXNpemVfdCBzaXplOw0KPiAgfTsNCj4g IA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRl diBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2