Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: vitaly prosyak <vprosyak@amd.com>
To: Tim Huang <tim.huang@amd.com>, igt-dev@lists.freedesktop.org
Cc: vitaly.prosyak@amd.com, alexander.deucher@amd.com, jie1zhan@amd.com
Subject: Re: [PATCH i-g-t] tests/amdgpu: fix a random P-state test failure
Date: Thu, 5 Sep 2024 17:20:38 -0400	[thread overview]
Message-ID: <35bed225-69e0-48d9-9f88-b4154381407d@amd.com> (raw)
In-Reply-To: <20240905100750.521280-1-tim.huang@amd.com>

Thanks for fixing this long-standing typo in the code. It’s been around for quite some time!

Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>

On 2024-09-05 06:07, Tim Huang wrote:
> We should use the current_pstate to compare
> with the default UMD stable P-state.
>
> Signed-off-by: Tim Huang <tim.huang@amd.com>
> ---
>  tests/amdgpu/amd_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_pstate.c b/tests/amdgpu/amd_pstate.c
> index 9a7873538..2bc794252 100644
> --- a/tests/amdgpu/amd_pstate.c
> +++ b/tests/amdgpu/amd_pstate.c
> @@ -23,7 +23,7 @@ amdgpu_stable_pstate_test(amdgpu_device_handle device_handle)
>  					AMDGPU_CTX_OP_GET_STABLE_PSTATE,
>  					0, &current_pstate);
>  	igt_assert_eq(r, 0);
> -	igt_assert_eq(new_pstate, AMDGPU_CTX_STABLE_PSTATE_NONE);
> +	igt_assert_eq(current_pstate, AMDGPU_CTX_STABLE_PSTATE_NONE);
>  	r = amdgpu_cs_ctx_stable_pstate(context_handle,
>  					AMDGPU_CTX_OP_SET_STABLE_PSTATE,
>  					AMDGPU_CTX_STABLE_PSTATE_PEAK, NULL);

  reply	other threads:[~2024-09-05 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 10:07 [PATCH i-g-t] tests/amdgpu: fix a random P-state test failure Tim Huang
2024-09-05 21:20 ` vitaly prosyak [this message]
2024-09-05 22:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-05 22:11 ` ✓ CI.xeBAT: " Patchwork
2024-09-08  0:57 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-09 23:01 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35bed225-69e0-48d9-9f88-b4154381407d@amd.com \
    --to=vprosyak@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jie1zhan@amd.com \
    --cc=tim.huang@amd.com \
    --cc=vitaly.prosyak@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox