From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6734B10E34D
 for <igt-dev@lists.freedesktop.org>; Tue, 26 Sep 2023 05:58:35 +0000 (UTC)
Message-ID: <36072188-701d-42de-2c73-76b0af077b65@intel.com>
Date: Tue, 26 Sep 2023 11:28:30 +0530
MIME-Version: 1.0
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
References: <20230922151937.1188567-1-jeevan.b@intel.com>
Content-Language: en-US
From: "Sharma, Swati2" <swati2.sharma@intel.com>
In-Reply-To: <20230922151937.1188567-1-jeevan.b@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for
 valid scenario
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

Please change subject to "Add comment for valid scenario"

Remaining LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 22-Sep-23 8:49 PM, Jeevan B wrote:
> Describe the valid scenario for 'basic-clone-single-crtc' and
> 'basic-clone-single-crtc' tests, as these tests are skipped if
> a valid scenario is not found, which can cause confusion during
> bug analysis.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> cc: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/kms_setmode.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index 32a6fb690..a669cc1df 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -979,6 +979,14 @@ const char *help_str =
>   	"  -t <test id>\tRun only the test with this id\n"
>   	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
>   
> +/*
> + * basic-clone-single-crtc allows the use of a single CRTC for two connectors, such as VGA/HDMI,
> + * VGA/DP, and HDMI/HDMI, which are the possible combinations. Similarly, for invalid-clone-exclusive-crtc,
> + * when a connector uses a CRTC that is not compatible with the connector, for instance, DP/HDMI
> + * can be used on certain pipes on old platforms.
> + */
> +
> +
>   igt_main_args("det:", NULL, help_str, opt_handler, NULL)
>   {
>   	const struct {