Re: [igt-dev] [PATCH i-g-t] runner: Use glib's regex utilities instead of POSIX ERE

Lyude Paul
2019-05-10T15:57:14Z

On Fri, 2019-05-10 at 12:22 +0300, Petri Latvala wrote:
> On Thu, May 09, 2019 at 08:06:04PM -0400, Lyude wrote:
> > From: Lyude Paul <lyude@redhat.com>
> >
> > POSIX ERE, while pretty standard is also very old and severely limited.
> > In fact, it's so limited that Intel CI's own test blacklist,
> > tests/intel-ci/blacklist.txt, doesn't even work with it due to the lack
> > of support for backreferences.
>
> Side note: Even with these changes, nothing can currently eat
> blacklist.txt as is. Sitting tightly in my TODO is to implement the
> final piece of the pipeline that CI uses piglit for with igt_runner,
> scripts/run-tests.sh -l, with something that can process
> blacklist.txt. These changes are the first step towards that, thanks
> for doing this.
>
> In other words, this doesn't implement what I guess you're trying to
> do but it's needed, so
sidenote: I have an ansible playbook I use for processing the blacklist as
well, when I was referring to the intel-ci blacklist I was just referring to
the actual entries in it - I'm aware this doesn't let you pass the blacklist
directly to igt! But, I figured having behavior like this would enable
something like you're trying to do and make us more consistent with piglit
anyway

Anyway-thanks for the review! will push in a moment

>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
--
Cheers,
Lyude Paul