Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"B, Jeevan" <jeevan.b@intel.com>
Subject: Re: [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport
Date: Fri, 31 May 2024 07:06:40 +0000	[thread overview]
Message-ID: <37719af6b9201dbd20c8c87c6d5f6293689ebe27.camel@intel.com> (raw)
In-Reply-To: <20240520094620.3713972-3-jeevan.b@intel.com>

On Mon, 2024-05-20 at 15:16 +0530, Jeevan B wrote:
> Add checks weather early transport if supported then
> we check if early trasport is working.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/intel/kms_psr2_sf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c
> index 4c3e34aa0..4908f2444 100644
> --- a/tests/intel/kms_psr2_sf.c
> +++ b/tests/intel/kms_psr2_sf.c
> @@ -916,6 +916,9 @@ static void run(data_t *data)
>                 igt_assert_f(intel_fbc_wait_until_enabled(data-
> >drm_fd,
>                                                           data-
> >pipe),
>                                                           "FBC still
> disabled\n");
> +       if (psr_sink_support(data->drm_fd, data->debugfs_fd, ET_MODE,
> NULL))
> +               igt_assert_f(psr2_early_transport_check(data-
> >debugfs_fd),
> +                            "PSR2 early transport not enabled\n");

You are adding new mode (ET_MODE) in previous patch. You should carry
it in data->psr_mode and modify set_sel_fetch_mode_for_output
accordingly. This way you could just rely on current checks. You need
to implement psr_active_check for this new mode in patch 01/02.

BR,

Jouni Högander

>  
>         data->screen_changes = 0;
>  


  reply	other threads:[~2024-05-31  7:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  9:46 [PATCH i-g-t 0/2] Early Transport Support Jeevan B
2024-05-20  9:46 ` [PATCH i-g-t 1/2] lib/igt_psr: Added library functions for early trasport Jeevan B
2024-05-31  6:54   ` Hogander, Jouni
2024-05-20  9:46 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport Jeevan B
2024-05-31  7:06   ` Hogander, Jouni [this message]
2024-05-20 15:27 ` ✓ CI.xeBAT: success for Early Transport Support Patchwork
2024-05-20 15:32 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-20 17:41 ` ✓ CI.xeFULL: " Patchwork
2024-05-21  5:18 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-06-12 11:06 [PATCH i-g-t 0/2] " Jeevan B
2024-06-12 11:06 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport Jeevan B
2024-06-13 10:41   ` Hogander, Jouni
2024-06-19 15:33     ` B, Jeevan
2024-06-20  4:33 [PATCH i-g-t 0/2] Early Transport Support Jeevan B
2024-06-20  4:33 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport Jeevan B
2024-06-24  9:19 [PATCH i-g-t 0/2] Early Transport Support Jeevan B
2024-06-24  9:19 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport Jeevan B
2024-06-24 18:15 [PATCH i-g-t 0/2] Early Transport Support Jeevan B
2024-06-24 18:15 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Add checks for early transport Jeevan B
2024-06-25  8:44   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37719af6b9201dbd20c8c87c6d5f6293689ebe27.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox