From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Fix flip timestamp checks
Date: Wed, 28 Apr 2021 17:38:32 +0300 [thread overview]
Message-ID: <37ccb526-04d4-ba4f-9378-d366ca532c8f@gmail.com> (raw)
In-Reply-To: <20210427222548.1778-1-ville.syrjala@linux.intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 28.4.2021 1.25, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Check the flip timestamp from the event (not the time we got the
> event) against the vblank timestamps. Also if things are going
> well we should expect the flip timestamp to in fact match the
> first vblank timestamp, so allow them to be equal.
>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_async_flips.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index e397a54b874f..a60eab688024 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -89,7 +89,7 @@ static void flip_handler(int fd_, unsigned int sequence, unsigned int tv_sec,
>
> last_ms = cur_ms;
>
> - data->flip_timestamp_us = ts.tv_sec * 1000000 + ts.tv_nsec / 1000;
> + data->flip_timestamp_us = tv_sec * 1000000l + tv_usec;
> }
>
> static void wait_flip_event(data_t *data)
> @@ -282,7 +282,7 @@ static void test_timestamp(data_t *data)
> igt_info("vbl1_timestamp = %ldus\nflip_timestamp = %ldus\nvbl2_timestamp = %ldus\n",
> vbl_time, data->flip_timestamp_us, vbl_time1);
>
> - igt_assert_f(vbl_time < data->flip_timestamp_us && vbl_time1 > data->flip_timestamp_us,
> + igt_assert_f(vbl_time <= data->flip_timestamp_us && vbl_time1 > data->flip_timestamp_us,
> "Async flip time stamp is expected to be in between 2 vblank time stamps\n");
> }
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-04-28 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 22:25 [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Fix flip timestamp checks Ville Syrjala
2021-04-27 23:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-04-28 2:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Fix flip timestamp checks (rev2) Patchwork
2021-04-28 5:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-28 14:38 ` Juha-Pekka Heikkila [this message]
2021-04-29 5:37 ` [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Fix flip timestamp checks Karthik B S
2021-04-29 15:32 ` Ville Syrjälä
2021-05-04 11:12 ` Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ccb526-04d4-ba4f-9378-d366ca532c8f@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox