From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] tests/drv_selftest: Allow passing in module options from the command line
Date: Tue, 20 Nov 2018 18:27:17 +0000 [thread overview]
Message-ID: <380c8239-5719-7f57-36a2-021d1d3496b3@linux.intel.com> (raw)
In-Reply-To: <154273781365.11623.18047213113245098824@skylake-alporthouse-com>
On 20/11/2018 18:16, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-20 18:07:57)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> A new option '--kmod-options' is added which takes a string which will be
>> passed to modprobe when loading the module.
>>
>> This for instance allows easy override of things like the random seed when
>> trying to reproduce failures.
>
> Anyway we can simply extend the option parsing locally? (Just find it
> unsightly to have test specific options in libigt.)
Well.. it is not test specific but kmod specific but point still stands.
> Stashing argc/argv in igt_subtest_init_parse_opts() and then being able
> to run getopts inside igt_main {}?
Yep, I didn't know we have this already.
> I also had in mind an env for module options, which may be also useful
> for the module reloading and autoloading.
In that case, since modprobe(8) supports MODPROBE_OPTIONS, we could
perhaps emulate that in igt_kmod? Or add support directly to libkmod?
With either we wouldn't even need the command line pass through. Adding
Lucas for an opinion since kmod seems to be his baby.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-11-20 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 18:07 [igt-dev] [PATCH i-g-t] tests/drv_selftest: Allow passing in module options from the command line Tvrtko Ursulin
2018-11-20 18:16 ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-11-20 18:20 ` Chris Wilson
2018-11-20 18:27 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380c8239-5719-7f57-36a2-021d1d3496b3@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox