From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Sk Anirban <sk.anirban@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <riana.tauro@intel.com>,
<karthik.poosa@intel.com>, <raag.jadav@intel.com>,
<soham.purkait@intel.com>, <mallesh.koujalagi@intel.com>,
<vinay.belgaumkar@intel.com>
Subject: Re: [PATCH] tests/intel/perf_pmu: Ignore SLPC efficient freq during test
Date: Tue, 5 May 2026 21:32:15 +0530 [thread overview]
Message-ID: <389b5c8f-e0aa-4143-b02e-c2383c43ba07@intel.com> (raw)
In-Reply-To: <20260409090750.546999-2-sk.anirban@intel.com>
On 09-04-2026 14:37, Sk Anirban wrote:
> Disable SLPC efficient frequency before pinning the GPU to min/max
> frequency ranges. This ensures the driver-requested frequency stays
> within the desired range during measurement.
> Without this, SLPC may override the pinned frequency, causing the
> test to report values outside the expected min/max bounds.
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12549
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
> tests/intel/perf_pmu.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/intel/perf_pmu.c b/tests/intel/perf_pmu.c
> index 661ead32d..1e389958f 100644
> --- a/tests/intel/perf_pmu.c
> +++ b/tests/intel/perf_pmu.c
> @@ -1521,6 +1521,8 @@ test_frequency(int gem_fd, unsigned int gt)
> fd[0] = open_group(gem_fd, __I915_PMU_REQUESTED_FREQUENCY(gt), -1);
> fd[1] = open_group(gem_fd, __I915_PMU_ACTUAL_FREQUENCY(gt), fd[0]);
>
> + igt_pm_ignore_slpc_efficient_freq(gem_fd, sysfs, true);
> +
> /*
> * Set GPU to min frequency and read PMU counters.
> */
> @@ -1586,8 +1588,11 @@ test_frequency(int gem_fd, unsigned int gt)
> igt_warn_on_f(read_value != min_freq,
> "Unable to restore min frequency to saved value [%u MHz], now %u MHz\n",
> min_freq, read_value);
> + igt_pm_ignore_slpc_efficient_freq(gem_fd, sysfs, false);
> +
> close(fd[0]);
> close(fd[1]);
> + close(sysfs);
LGTM.
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Thanks,
Badal
> put_ahnd(ahnd);
>
> igt_info("Min frequency: requested %.1f, actual %.1f\n",
prev parent reply other threads:[~2026-05-05 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 9:07 [PATCH] tests/intel/perf_pmu: Ignore SLPC efficient freq during test Sk Anirban
2026-04-10 2:12 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-10 2:18 ` ✓ i915.CI.BAT: " Patchwork
2026-04-10 5:24 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-06 9:03 ` Anirban, Sk
2026-04-10 20:32 ` ✓ i915.CI.Full: success " Patchwork
2026-05-05 16:02 ` Nilawar, Badal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=389b5c8f-e0aa-4143-b02e-c2383c43ba07@intel.com \
--to=badal.nilawar@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=sk.anirban@intel.com \
--cc=soham.purkait@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox