Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Gupta, Nidhi1" <nidhi1.gupta@intel.com>
To: "Hagaragi, Arundhati" <arundhati.hagaragi@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_atomic_transition:Add subtest description
Date: Fri, 26 Feb 2021 02:52:10 +0000	[thread overview]
Message-ID: <3994960cbc7145ec8535145a021e2e91@intel.com> (raw)
In-Reply-To: <20210219090037.655641-1-arundhati.hagaragi@intel.com>

LGTM
Reviewed-by: Nidhi Gupta

-----Original Message-----
From: Arundhati Hagaragi <arundhati.hagaragi@intel.com> 
Sent: Friday, February 19, 2021 2:31 PM
To: igt-dev@lists.freedesktop.org
Cc: Hagaragi, Arundhati <arundhati.hagaragi@intel.com>; Gupta; Gupta, Nidhi1 <nidhi1.gupta@intel.com>
Subject: [PATCH i-g-t v2] tests/kms_atomic_transition:Add subtest description

Added description for all subtests

Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi@intel.com>
Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
---
 tests/kms_atomic_transition.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index e75cc637..9689bf4d 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -993,6 +993,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			count++;
 	}
 
+	igt_describe("Check toggling of primary plane with vblank");
 	igt_subtest("plane-primary-toggle-with-vblank-wait")
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1002,6 +1003,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 		}
 
+	igt_describe("Transition test for all plane combinations");
 	igt_subtest_with_dynamic("plane-all-transition") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1012,6 +1014,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Transition test for all plane combinations with fencing 
+commit");
 	igt_subtest_with_dynamic("plane-all-transition-fencing") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1022,6 +1025,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Transition test for all plane combinations with 
+nonblocking commit");
 	igt_subtest_with_dynamic("plane-all-transition-nonblocking") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1032,6 +1036,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Transition test for all plane combinations with 
+nonblocking and fencing commit");
 	igt_subtest_with_dynamic("plane-all-transition-nonblocking-fencing") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1042,6 +1047,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Transition test with non blocking commit and make sure commit of disabled plane has "
+		       "to complete before atomic commit on that plane");
 	igt_subtest_with_dynamic("plane-use-after-nonblocking-unbind") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1052,6 +1059,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Transition test with non blocking and fencing commit and make sure commit of "
+		       "disabled plane has to complete before atomic commit on that 
+plane");
 	igt_subtest_with_dynamic("plane-use-after-nonblocking-unbind-fencing") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1067,6 +1076,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	 * number of combinations, to avoid long runtimes due to modesets on
 	 * panels with long power cycle delays.
 	 */
+	igt_describe("Modeset test for all plane combinations");
 	igt_subtest_with_dynamic("plane-all-modeset-transition")
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1079,6 +1089,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 				run_transition_test(&data, pipe, output, TRANSITION_MODESET, false, false);
 		}
 
+	igt_describe("Modeset test for all plane combinations with fencing 
+commit");
 	igt_subtest_with_dynamic("plane-all-modeset-transition-fencing")
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1091,6 +1102,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 				run_transition_test(&data, pipe, output, TRANSITION_MODESET, false, true);
 		}
 
+	igt_describe("Modeset test for all plane combinations on internal 
+panels");
 	igt_subtest_with_dynamic("plane-all-modeset-transition-internal-panels") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1104,6 +1116,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Modeset test for all plane combinations on internal 
+panels with fencing commit");
 	igt_subtest_with_dynamic("plane-all-modeset-transition-fencing-internal-panels") {
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1117,6 +1130,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Check toggling and modeset transition on plane");
 	igt_subtest("plane-toggle-modeset-transition")
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
 			if (pipe_count == 2 * count && !data.extended) @@ -1125,6 +1139,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			run_transition_test(&data, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
 		}
 
+	igt_describe("Modeset transition tests for combinations of crtc 
+enabled");
 	igt_subtest_with_dynamic("modeset-transition") {
 		for (i = 1; i <= count; i++) {
 			igt_dynamic_f("%ix-outputs", i)
@@ -1132,6 +1147,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Modeset transition tests for combinations of crtc 
+enabled with nonblocking commit");
 	igt_subtest_with_dynamic("modeset-transition-nonblocking") {
 		for (i = 1; i <= count; i++) {
 			igt_dynamic_f("%ix-outputs", i)
@@ -1139,6 +1155,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Modeset transition tests for combinations of crtc 
+enabled with fencing commit");
 	igt_subtest_with_dynamic("modeset-transition-fencing") {
 		for (i = 1; i <= count; i++) {
 			igt_dynamic_f("%ix-outputs", i)
@@ -1146,6 +1163,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Modeset transition tests for combinations of crtc enabled with nonblocking &"
+		       " fencing commit");
 	igt_subtest_with_dynamic("modeset-transition-nonblocking-fencing") {
 		for (i = 1; i <= count; i++) {
 			igt_dynamic_f("%ix-outputs", i)
--
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-02-26  2:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  9:00 [igt-dev] [PATCH i-g-t v2] tests/kms_atomic_transition:Add subtest description Arundhati Hagaragi
2021-02-19 10:20 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_atomic_transition:Add subtest description (rev2) Patchwork
2021-02-19 14:04 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-26  2:52 ` Gupta, Nidhi1 [this message]
2021-02-26  3:19 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_transition:Add subtest description (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3994960cbc7145ec8535145a021e2e91@intel.com \
    --to=nidhi1.gupta@intel.com \
    --cc=arundhati.hagaragi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox