From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8DC1C3DA63 for ; Thu, 18 Jul 2024 13:04:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DBF210E825; Thu, 18 Jul 2024 13:04:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nY0+VXEY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0455110E81C for ; Thu, 18 Jul 2024 13:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721307851; x=1752843851; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xKAxyIeV9H5rvDqU1KsCXADEz6QNvBNd8U8dhRIjVfQ=; b=nY0+VXEYCG1xKqv5GnerFWHbczgvb31IWBmySW8JQ4fZShsHP6poA7fG JbFyErsxLaXpSZD41W+POA8ReFAzzpC4nyfnatYgpPliBbH15m6aE5WN5 7KdHH4zbpLcLTGtANbWRuKuvC0wA90P+Qo7uBmYRpELrhkNkbuwmeO+6t nAvbzFmgcw+XsCe00MdwOHneISNHGDeZB8sFdQaqy/2FGsC8qa6eaojIV gxCowbVYDNPJ8Izt1j6gGF7diIFKS56cBK9YEJgz9xREJn6xhQQuuWLDg /4I10Jh1gp2RoOrXoUa/WU7X/a0aqeoal9L47r+hBGXZDDXqodn3atiwi Q==; X-CSE-ConnectionGUID: ptkQGIN4TtS49IgKGm8MzA== X-CSE-MsgGUID: jA6hXhGKRDGi1GQ9hb1wxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11137"; a="36306785" X-IronPort-AV: E=Sophos;i="6.09,217,1716274800"; d="scan'208";a="36306785" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 06:04:11 -0700 X-CSE-ConnectionGUID: hh88MTKrSSKbgHCPUMpRrA== X-CSE-MsgGUID: N5XW3qawQUeaqEdrctNj2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,217,1716274800"; d="scan'208";a="81778804" Received: from mbernato-mobl1.ger.corp.intel.com (HELO [10.246.28.172]) ([10.246.28.172]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 06:04:08 -0700 Message-ID: <3b1ed04c-4044-4a50-8027-f32ed45ecb41@linux.intel.com> Date: Thu, 18 Jul 2024 15:04:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t] tests/intel-ci/xe-sriov-vf.blocklist.txt: Blocklist for SR-IOV VF BAT runs To: Michal Wajdeczko , igt-dev@lists.freedesktop.org Cc: Adam Miszczak , Lukasz Laguna , Jakub Kolakowski , Kamil Konieczny References: <20240717153051.1000030-1-marcin.bernatowicz@linux.intel.com> Content-Language: en-US From: "Bernatowicz, Marcin" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On 7/18/2024 12:37 PM, Michal Wajdeczko wrote: > > > On 17.07.2024 17:30, Marcin Bernatowicz wrote: >> Blocklist tests not applicable for Virtual Function (VF) BAT runs. > > is this 'VF BAT run' about running IGTs in VM, or it's something different? > it's about running BAT tests on VF device not in VM >> The list extends xe.blocklist.txt to enable xe-fast-feedback.testlist >> execution on VF device. > > maybe it's just a outdated doc, but README [1] says that blocklist is > only applied to *FULL* not *BAT* runs: > > "blacklist.txt > > This file contains regular expressions (one per line) for tests that are > not to be executed in full suite test rounds." > > [1] > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tests/intel-ci/README?ref_type=heads > looks outdated doc >> >> Cc: Adam Miszczak >> Cc: Lukasz Laguna >> Cc: Jakub Kolakowski >> Cc: Michal Wajdeczko >> Cc: Kamil Konieczny >> Signed-off-by: Marcin Bernatowicz >> --- >> tests/intel-ci/meson.build | 1 + >> tests/intel-ci/xe-sriov-vf.blocklist.txt | 21 +++++++++++++++++++++ >> 2 files changed, 22 insertions(+) >> create mode 100644 tests/intel-ci/xe-sriov-vf.blocklist.txt >> >> diff --git a/tests/intel-ci/meson.build b/tests/intel-ci/meson.build >> index f16243cbb..59323eda9 100644 >> --- a/tests/intel-ci/meson.build >> +++ b/tests/intel-ci/meson.build >> @@ -11,6 +11,7 @@ intelci_files = [ >> 'xe.blocklist.txt', >> 'xe-fast-feedback.testlist', >> 'xe-fast-feedback-chamelium-only.testlist', >> + 'xe-sriov-vf.blocklist.txt', >> ] >> >> install_data(sources : intelci_files, install_dir : datadir) >> diff --git a/tests/intel-ci/xe-sriov-vf.blocklist.txt b/tests/intel-ci/xe-sriov-vf.blocklist.txt >> new file mode 100644 >> index 000000000..dae20bc6c >> --- /dev/null >> +++ b/tests/intel-ci/xe-sriov-vf.blocklist.txt > > not a CI expert, but if there is: > > xe-fast-feedback.testlist > > then maybe corresponding blocklist should be named: > > xe-fast-feedback.vf.blocklist > > (and btw, I'm wondering why blocklists have .txt extension while > testlists correctly don't have it) > kept naming after xe.blocklist.txt > > >> @@ -0,0 +1,21 @@ >> +################################################################## >> +# Block list for VF xe-fast-feedback runs >> +################################################################## >> +# The module is already loaded when VF is created >> +################################################################## >> +igt@xe_module_load > > if tests are executed inside the VM then testing a module reload is > something that we want to have, no? tests are executed on VF device not inside VM > >> +################################################################## >> +# Not applicable on VF >> +################################################################## >> +igt@fbdev > > some devices don't have display (like ATSM) and likely don't have > dedicated .blocklist for them, so maybe it's fine that these tests will > SKIP (unless there will be separate BAT.display run introduced, where we > can also run kms tests) blocked as currently skips on all platforms with SR-IOV enabled > >> +igt@sriov_basic >> +igt@kms.* >> +igt@xe_gt_freq >> +igt@xe_live_ktest > > only individual live-testcases might be N/A for VFs, but in general we > want to be able to execute live-tests on the VF > > see [2] how this will be improved soon > > [2] https://patchwork.freedesktop.org/patch/604990/?series=136163&rev=2 will look at it > >> +igt@xe_pm_residency >> +################################################################## >> +# Under investigation > > what does it mean? > is it broken test or broken VF driver? > do we track those failures anywhere? may be both, we want to start with clean execution first failures are internally tracked at the moment > >> +################################################################## >> +igt@xe_debugfs@gt >> +igt@xe_evict_ccs@evict-overcommit-simple >> +igt@xe_evict_ccs@evict-overcommit-parallel-nofree-samefd