Re: FW: [PATCH i-g-t v2 1/2] tests/kms_flip: Updating the skip message

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]


On 11/7/2024 7:10 PM, Samala, Pranay wrote:
>
> -----Original Message-----
> From: Samala, Pranay<pranay.samala@intel.com> 
> Sent: Wednesday, November 6, 2024 3:30 PM
> To:igt-dev@lists.freedesktop.org
> Cc: B S, Karthik<karthik.b.s@intel.com>; Naladala, Ramanaidu<ramanaidu.naladala@intel.com>; Lattannavar, Sameer<sameer.lattannavar@intel.com>; Samala, Pranay<pranay.samala@intel.com>
> Subject: [PATCH i-g-t v2 1/2] tests/kms_flip: Updating the skip message
>
> Debugging would be easier if we had logs available for test failures and skips. This patch rephrases the skip message for better understanding.
>
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   tests/kms_flip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c index cbabbe74f..88cd41083 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
>   
>   	/* If we have fewer than 2 connected outputs then we won't have any
>   	 * configuration at all. So skip in that case. */
> -	igt_require_f(modes, "At least two displays required\n");
> +	igt_require_f(modes, "At least two displays with same modes are
> +required\n");

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com> 
<mailto:ramanaidu.naladala@intel.com>

>   
>   	if (duration) {
>   		duration = duration * 1000 / modes;
> --
> 2.34.1
>

[-- Attachment #2: Type: text/html, Size: 38211 bytes --]