Re: [igt-dev] [PATCH i-g-t 2/2] test/intel/xe_guc_pc: Fix freq_low_max test

["Belgaumkar, Vinay" <vinay.belgaumkar@intel.com>]

On 11/24/2023 2:29 AM, Badal Nilawar wrote:
> freq_low_max test is intended to validate GuC PC (SLPC) behaviour
> when max freq set to less than min freq. As workloads are not being
> run validating cur freq is enough.
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   tests/intel/xe_guc_pc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/intel/xe_guc_pc.c b/tests/intel/xe_guc_pc.c
> index c23017501..70548ba0e 100644
> --- a/tests/intel/xe_guc_pc.c
> +++ b/tests/intel/xe_guc_pc.c
> @@ -220,7 +220,6 @@ static void test_freq_low_max(int fd, int gt_id)
>   	igt_assert(set_freq(fd, gt_id, "max", rpn) > 0);
>   	usleep(ACT_FREQ_LATENCY_US);
>   	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
> -	igt_assert(get_freq(fd, gt_id, "act") == rpe);

might be worth keeping this check with if (!in_rc6()). We hardly check 
for actual frequency, this will be a good way to ensure we can even get 
efficient freq.

Thanks,

Vinay.

>   }
>   
>   /**