Re: [PATCH i-g-t] tests/kms_plane: Allow planar-pixel-format-settings to pass on VKMS

[Louis Chauvet <louis.chauvet@bootlin.com>]

On 3/20/26 11:16, Kamil Konieczny wrote:
> From: Renjun Wang <renjunw0@foxmail.com>
> 
> Enable planar-pixel-format-settings subtests when running on VKMS
> driver. VKMS currently accepts odd width|height for NV12, odd
> horizontal panning for NV12, and odd vertical panning for P016
> format.
> 
> v2: remove is_intel var (Kamil), keep all comments (Swati)
> 
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Does it make sense to rename display_ver to intel_display_ver?

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>   tests/kms_plane.c | 35 +++++++++++++++++++++++------------
>   1 file changed, 23 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index d5bab62bb..7f7e2d9a6 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1365,11 +1365,8 @@ static void test_planar_settings(data_t *data)
>   	int devid;
>   	int display_ver = -1;
>   	int rval;
> +	bool is_vkms = false;
>   
> -	/*
> -	 * If here is added non-intel tests below require will need to be
> -	 * changed to if(..)
> -	 */
>   	igt_require_f(data->display.is_atomic, "Atomic mode-set not supported\n");
>   	if (is_intel_device(data->drm_fd)) {
>   		igt_require_intel(data->drm_fd);
> @@ -1377,6 +1374,8 @@ static void test_planar_settings(data_t *data)
>   		igt_require(intel_display_ver(devid) >= 9);
>   		display_ver = intel_display_ver(devid);
>   		igt_require(display_ver >= 9);
> +	} else if (is_vkms_device(data->drm_fd)) {
> +		is_vkms = true;
>   	}
>   
>   	crtc = igt_first_crtc_with_single_output(display, &output);
> @@ -1387,13 +1386,15 @@ static void test_planar_settings(data_t *data)
>   	igt_display_commit_atomic(&data->display,
>   				  DRM_MODE_ATOMIC_ALLOW_MODESET,
>   				  NULL);
> -
> -	/* test against intel_plane_check_src_coordinates() in i915 */
> +	/*
> +	 * Test odd width for NV12 format.
> +	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
> +	 */
>   	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
>   				     DRM_FORMAT_MOD_LINEAR)) {
>   		int expected_rval = -EINVAL;
>   
> -		if (display_ver >= 20)
> +		if (display_ver >= 20 || is_vkms)
>   			expected_rval = 0;
>   
>   		igt_create_fb(data->drm_fd, 257, 256,
> @@ -1409,12 +1410,15 @@ static void test_planar_settings(data_t *data)
>   		igt_debug("Odd width NV12 framebuffer test skipped\n");
>   	}
>   
> -	/* test against intel_plane_check_src_coordinates() in i915 */
> +	/*
> +	 * Test odd height for NV12 format.
> +	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
> +	 */
>   	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
>   				     DRM_FORMAT_MOD_LINEAR)) {
>   		int expected_rval = -EINVAL;
>   
> -		if (display_ver >= 20 && display_ver < 35)
> +		if ((display_ver >= 20 && display_ver < 35) || is_vkms)
>   			expected_rval = 0;
>   
>   		igt_create_fb(data->drm_fd, 256, 257,
> @@ -1430,12 +1434,15 @@ static void test_planar_settings(data_t *data)
>   		igt_debug("Odd height NV12 framebuffer test skipped\n");
>   	}
>   
> -	/* test against intel_plane_check_src_coordinates() in i915 */
> +	/*
> +	 * Test odd horizontal panning for NV12 format.
> +	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
> +	 */
>   	if (igt_plane_has_format_mod(primary, DRM_FORMAT_NV12,
>   				     DRM_FORMAT_MOD_LINEAR)) {
>   		int expected_rval = -EINVAL;
>   
> -		if (display_ver >= 35)
> +		if (display_ver >= 35 || is_vkms)
>   			expected_rval = 0;
>   
>   		igt_create_fb(data->drm_fd, 810, 590,
> @@ -1452,11 +1459,15 @@ static void test_planar_settings(data_t *data)
>   		igt_debug("Odd horizontal pan NV12 framebuffer test skipped\n");
>   	}
>   
> +	/*
> +	 * Test odd vertical panning for P016 format.
> +	 * For Intel i915/xe test against intel_plane_check_src_coordinates()
> +	 */
>   	if (igt_plane_has_format_mod(primary, DRM_FORMAT_P016,
>   					    DRM_FORMAT_MOD_LINEAR)) {
>   		int expected_rval = -EINVAL;
>   
> -		if (display_ver >= 20 && display_ver < 35)
> +		if ((display_ver >= 20 && display_ver < 35) || is_vkms)
>   			expected_rval = 0;
>   
>   		igt_create_color_fb(data->drm_fd, 256, 260,