From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 521C810E0F5 for ; Fri, 29 Sep 2023 09:35:17 +0000 (UTC) Message-ID: <3d25cb8c-83b6-5bd4-181a-58d8066d4615@linux.intel.com> Date: Fri, 29 Sep 2023 10:35:13 +0100 MIME-Version: 1.0 Content-Language: en-US To: Marcin Bernatowicz , igt-dev@lists.freedesktop.org References: <20230928174535.2074462-1-marcin.bernatowicz@linux.intel.com> <20230928174535.2074462-16-marcin.bernatowicz@linux.intel.com> From: Tvrtko Ursulin In-Reply-To: <20230928174535.2074462-16-marcin.bernatowicz@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t 15/17] benchmarks/gem_wsim: introduce bb_size in w_step List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chris.p.wilson@linux.intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 28/09/2023 18:45, Marcin Bernatowicz wrote: > Put it next to bb_handle. > Use it in alloc_step_batch and measure_active_set. Could say why. Like xe might need more than 4k? Might not be able to allocate only 4k? (Guessing only.) Regards, Tvrtko > Signed-off-by: Marcin Bernatowicz > --- > benchmarks/gem_wsim.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c > index 4618509ab..d22d66aeb 100644 > --- a/benchmarks/gem_wsim.c > +++ b/benchmarks/gem_wsim.c > @@ -183,6 +183,7 @@ struct w_step { > } i915; > }; > uint32_t bb_handle; > + size_t bb_size; > }; > > struct ctx { > @@ -1481,6 +1482,7 @@ alloc_step_batch(struct workload *wrk, struct w_step *w) > unsigned int nr_obj = 2 + w->data_deps.nr; > unsigned int i; > > + w->bb_size = 4096; > w->i915.obj = calloc(nr_obj, sizeof(*w->i915.obj)); > igt_assert(w->i915.obj); > > @@ -1522,7 +1524,7 @@ alloc_step_batch(struct workload *wrk, struct w_step *w) > igt_assert(j < nr_obj); > } > > - w->bb_handle = w->i915.obj[j].handle = gem_create(fd, 4096); > + w->bb_handle = w->i915.obj[j].handle = gem_create(fd, w->bb_size); > w->i915.obj[j].relocation_count = create_bb(w, j); > igt_assert(w->i915.obj[j].relocation_count <= ARRAY_SIZE(w->i915.reloc)); > w->i915.obj[j].relocs_ptr = to_user_pointer(&w->i915.reloc); > @@ -1722,7 +1724,7 @@ static void measure_active_set(struct workload *wrk) > if (w->type != BATCH) > continue; > > - batch_sizes += 4096; > + batch_sizes += w->bb_size; > > for (j = 0; j < w->data_deps.nr; j++) { > struct dep_entry *dep = &w->data_deps.list[j];