From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>, Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 5/5] test/prime_vgem: use the gem_engine_topology library
Date: Thu, 6 Jun 2019 15:38:36 +0100 [thread overview]
Message-ID: <3d9d21b8-1679-433d-1c6e-5a0abc2bbcd2@linux.intel.com> (raw)
In-Reply-To: <20190606141701.GE1330@intel.intel>
On 06/06/2019 15:17, Andi Shyti wrote:
> Hi Ram,
>
> just a nitpick
>
>> - execbuf.flags = ring | flags;
>> + execbuf.flags = e ? e->flags : I915_EXEC_DEFAULT;
>
> Because we are moving to the new engine naming, the
> "I915_EXEC_DEFAULT" engine, conceptually, should not be used.
>
> Politically, with Tvrtko, we agreed that he default engine now
> is "I915_ENGINE_CLASS_RENDER", it's not the best as solution, but
> works.
I totally don't remember I ever suggested to use class or even it was
discussed. :) Didn't we say to just use zero?
Regards,
Tvrtko
> The rest looks good.
>
> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> Thanks,
> Andi
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-06 14:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:42 [igt-dev] [PATCH i-g-t v2 0/5] Engine discovery for few more tests Ramalingam C
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 1/5] test/i915: gem_bad_reloc: use the gem_engine_topology library Ramalingam C
2019-06-06 14:06 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 2/5] test/i915: gem_exec_async: " Ramalingam C
2019-05-30 15:44 ` Chris Wilson
2019-05-30 16:14 ` Ramalingam C
2019-06-06 14:09 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 3/5] test/i915: gem_exec_capture: " Ramalingam C
2019-05-30 15:47 ` Chris Wilson
2019-05-30 15:59 ` Ramalingam C
2019-06-06 14:10 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 4/5] test/i915: gem_exec_params: " Ramalingam C
2019-05-30 15:49 ` Chris Wilson
2019-05-30 16:13 ` Ramalingam C
2019-06-06 14:12 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 5/5] test/prime_vgem: " Ramalingam C
2019-05-30 15:50 ` Chris Wilson
2019-05-30 16:05 ` Ramalingam C
2019-06-06 14:17 ` Andi Shyti
2019-06-06 14:38 ` Tvrtko Ursulin [this message]
2019-06-06 15:31 ` Ramalingam C
2019-06-06 15:34 ` Tvrtko Ursulin
2019-06-06 15:48 ` Ramalingam C
2019-06-06 15:57 ` Tvrtko Ursulin
2019-06-07 10:38 ` Andi Shyti
2019-06-07 10:34 ` Andi Shyti
2019-05-31 11:11 ` [igt-dev] ✓ Fi.CI.BAT: success for Engine discovery for few more tests Patchwork
2019-06-01 2:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9d21b8-1679-433d-1c6e-5a0abc2bbcd2@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox