Re: [PATCH v3 03/10] lib/igt_drm_netlink: Introduce DRM RAS Netlink interface library

["Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com>]

On 31-08-2026 18:03, Jani Nikula wrote:
> On Mon, 31 Aug 2026, "Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com> wrote:
>> On 31-08-2026 14:16, Jani Nikula wrote:
>>> On Mon, 24 Aug 2026, Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com> wrote:
>>>> +struct app_context {
>>> Why doesn't the name indicate netlink in any way?z
>> I am using this structure to maintain the context of request received
>> for the library functions and responses received from netlink functions.
>> So I have not included netlink or nl for this structure name.
> "struct app_context" in code seems too generic. If you see that alone,
> you have no idea what it's related to.
>
> I don't know, I guess I would've named it struct
> igt_drm_netlink_<something>.
I will update it in the next revision. Thanks
>>>> +	struct nl_sock *sock;
>>>> +	int family_id;
>>>> +};
>>>> +
>>>> +void igt_cleanup_nl_socket(struct app_context *ctx);
>>>> +int igt_init_nl_socket(struct app_context *ctx);
>>> IMO "nl" is the wrong place to abbreviate.
>> libnl is the user space library used to communicate with DRM netlink
>> socket in the kernel. All libnl API references have the word "nl" for
>> netlink. So, I have followed the same in my library functions as well.
>> Could you pls elaborate your suggestion, if am missing anything here.
> I guess I would've named them igt_drm_netlink_{init,cleanup}().
I will update it in the next revision. Thanks
>
> BR,
> Jani.
>
>