From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com
 [209.85.222.194])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 540976E0AE
 for <igt-dev@lists.freedesktop.org>; Tue, 15 Jan 2019 22:05:20 +0000 (UTC)
Received: by mail-qk1-f194.google.com with SMTP id o125so2568426qkf.3
 for <igt-dev@lists.freedesktop.org>; Tue, 15 Jan 2019 14:05:20 -0800 (PST)
Message-ID: <3dbd652f4652f22fb3024cf3c56c8930f6007990.camel@redhat.com>
From: Lyude Paul <lyude@redhat.com>
Date: Tue, 15 Jan 2019 17:05:17 -0500
In-Reply-To: <20190111090532.19235-17-paul.kocialkowski@bootlin.com>
References: <20190111090532.19235-1-paul.kocialkowski@bootlin.com>
 <20190111090532.19235-17-paul.kocialkowski@bootlin.com>
Mime-Version: 1.0
Subject: Re: [igt-dev] [PATCH i-g-t v3 16/21] lib/igt_chamelium: Split
 frames dump logic and rework surroundings
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>, igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>, Eben Upton <eben@raspberrypi.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
List-ID: <igt-dev@lists.freedesktop.org>

T24gRnJpLCAyMDE5LTAxLTExIGF0IDEwOjA1ICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90
ZToKPiBUaGUgZnJhbWUgZHVtcCBsb2dpYyBpcyB0aGUgc2FtZSBmb3IgYWxsIGNvbXBhcmlzb24g
aGVscGVycywgc28gc3BsaXQKPiBpdCB0byBhIGRlZGljYXRlZCBmdW5jdGlvbiBhbmQgYWRhcHQg
aGVscGVycyB1c2luZyBpdCB0byBhdm9pZAo+IGR1cGxpY2F0aW5nIG9wZXJhdGlvbnMuCj4gCj4g
U2lnbmVkLW9mZi1ieTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3Rs
aW4uY29tPgo+IC0tLQo+ICBsaWIvaWd0X2NoYW1lbGl1bS5jIHwgODYgKysrKysrKysrKysrKysr
KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNl
cnRpb25zKCspLCAzNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9jaGFt
ZWxpdW0uYyBiL2xpYi9pZ3RfY2hhbWVsaXVtLmMKPiBpbmRleCAwYjZhYzM3YTNkODkuLjU5NjZi
NWNlMDc0MyAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2NoYW1lbGl1bS5jCj4gKysrIGIvbGliL2ln
dF9jaGFtZWxpdW0uYwo+IEBAIC0xMjQsNiArMTI0LDkgQEAgc3RydWN0IGNoYW1lbGl1bSB7Cj4g
IAo+ICBzdGF0aWMgc3RydWN0IGNoYW1lbGl1bSAqY2xlYW51cF9pbnN0YW5jZTsKPiAgCj4gK3N0
YXRpYyB2b2lkIGNoYW1lbGl1bV9kb19jYWxjdWxhdGVfZmJfY3JjKGNhaXJvX3N1cmZhY2VfdCAq
ZmJfc3VyZmFjZSwKPiArCQkJCQkgIGlndF9jcmNfdCAqb3V0KTsKPiArCj4gIC8qKgo+ICAgKiBj
aGFtZWxpdW1fZ2V0X3BvcnRzOgo+ICAgKiBAY2hhbWVsaXVtOiBUaGUgQ2hhbWVsaXVtIGluc3Rh
bmNlIHRvIHVzZQo+IEBAIC05NjcsNiArOTcwLDM5IEBAIHN0YXRpYyBjYWlyb19zdXJmYWNlX3Qg
KmNvbnZlcnRfZnJhbWVfZHVtcF9hcmdiMzIoY29uc3QKPiBzdHJ1Y3QgY2hhbWVsaXVtX2ZyYW1l
X2QKPiAgCXJldHVybiBkdW1wX3N1cmZhY2U7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGNvbXBh
cmVkX2ZyYW1lc19kdW1wKGNhaXJvX3N1cmZhY2VfdCAqcmVmZXJlbmNlLAo+ICsJCQkJIGNhaXJv
X3N1cmZhY2VfdCAqY2FwdHVyZSwKPiArCQkJCSBpZ3RfY3JjX3QgKnJlZmVyZW5jZV9jcmMsCj4g
KwkJCQkgaWd0X2NyY190ICpjYXB0dXJlX2NyYykKPiArewo+ICsJY2hhciAqcmVmZXJlbmNlX3N1
ZmZpeDsKPiArCWNoYXIgKmNhcHR1cmVfc3VmZml4Owo+ICsJaWd0X2NyY190IGxvY2FsX3JlZmVy
ZW5jZV9jcmM7Cj4gKwlpZ3RfY3JjX3QgbG9jYWxfY2FwdHVyZV9jcmM7Cj4gKwo+ICsJaWd0X2Fz
c2VydChyZWZlcmVuY2UgJiYgY2FwdHVyZSk7Cj4gKwo+ICsJaWYgKCFyZWZlcmVuY2VfY3JjKSB7
Cj4gKwkJY2hhbWVsaXVtX2RvX2NhbGN1bGF0ZV9mYl9jcmMocmVmZXJlbmNlLAo+ICZsb2NhbF9y
ZWZlcmVuY2VfY3JjKTsKPiArCQlyZWZlcmVuY2VfY3JjID0gJmxvY2FsX3JlZmVyZW5jZV9jcmM7
Cj4gKwl9Cj4gKwo+ICsJaWYgKCFjYXB0dXJlX2NyYykgewo+ICsJCWNoYW1lbGl1bV9kb19jYWxj
dWxhdGVfZmJfY3JjKHJlZmVyZW5jZSwgJmxvY2FsX2NhcHR1cmVfY3JjKTsKPiArCQljYXB0dXJl
X2NyYyA9ICZsb2NhbF9jYXB0dXJlX2NyYzsKPiArCX0KPiArCj4gKwlyZWZlcmVuY2Vfc3VmZml4
ID0gaWd0X2NyY190b19zdHJpbmdfZXh0ZW5kZWQocmVmZXJlbmNlX2NyYywgJy0nLCAyKTsKPiAr
CWNhcHR1cmVfc3VmZml4ID0gaWd0X2NyY190b19zdHJpbmdfZXh0ZW5kZWQoY2FwdHVyZV9jcmMs
ICctJywgMik7Cj4gKwo+ICsJLyogV3JpdGUgcmVmZXJlbmNlIGFuZCBjYXB0dXJlIGZyYW1lcyB0
byBwbmcuICovCj4gKwlpZ3Rfd3JpdGVfY29tcGFyZWRfZnJhbWVzX3RvX3BuZyhyZWZlcmVuY2Us
IGNhcHR1cmUsIHJlZmVyZW5jZV9zdWZmaXgsCj4gKwkJCQkJIGNhcHR1cmVfc3VmZml4KTsKPiAr
Cj4gKwlmcmVlKHJlZmVyZW5jZV9zdWZmaXgpOwo+ICsJZnJlZShjYXB0dXJlX3N1ZmZpeCk7Cj4g
K30KPiArCj4gIC8qKgo+ICAgKiBjaGFtZWxpdW1fYXNzZXJ0X2ZyYW1lX2VxOgo+ICAgKiBAY2hh
bWVsaXVtOiBUaGUgY2hhbWVsaXVtIGluc3RhbmNlIHRoZSBmcmFtZSBkdW1wIGJlbG9uZ3MgdG8K
PiBAQCAtMTAyOSw4ICsxMDY1LDYgQEAgdm9pZCBjaGFtZWxpdW1fYXNzZXJ0X2NyY19lcV9vcl9k
dW1wKHN0cnVjdCBjaGFtZWxpdW0KPiAqY2hhbWVsaXVtLAo+ICAJc3RydWN0IGNoYW1lbGl1bV9m
cmFtZV9kdW1wICpmcmFtZTsKPiAgCWNhaXJvX3N1cmZhY2VfdCAqcmVmZXJlbmNlOwo+ICAJY2Fp
cm9fc3VyZmFjZV90ICpjYXB0dXJlOwo+IC0JY2hhciAqcmVmZXJlbmNlX3N1ZmZpeDsKPiAtCWNo
YXIgKmNhcHR1cmVfc3VmZml4Owo+ICAJYm9vbCBlcTsKPiAgCj4gIAlpZ3RfZGVidWcoIlJlZmVy
ZW5jZSBDUkM6ICVzXG4iLCBpZ3RfY3JjX3RvX3N0cmluZyhyZWZlcmVuY2VfY3JjKSk7Cj4gQEAg
LTEwMzgsMjcgKzEwNzIsMTkgQEAgdm9pZCBjaGFtZWxpdW1fYXNzZXJ0X2NyY19lcV9vcl9kdW1w
KHN0cnVjdAo+IGNoYW1lbGl1bSAqY2hhbWVsaXVtLAo+ICAKPiAgCWVxID0gaWd0X2NoZWNrX2Ny
Y19lcXVhbChyZWZlcmVuY2VfY3JjLCBjYXB0dXJlX2NyYyk7Cj4gIAlpZiAoIWVxICYmIGlndF9m
cmFtZV9kdW1wX2lzX2VuYWJsZWQoKSkgewo+IC0JCS8qIEdyYWIgdGhlIHJlZmVyZW5jZSBmcmFt
ZSBmcm9tIGZyYW1lYnVmZmVyICovCj4gKwkJLyogQ29udmVydCB0aGUgcmVmZXJlbmNlIGZyYW1l
YnVmZmVyIHRvIGNhaXJvLiAqLwo+ICAJCXJlZmVyZW5jZSA9IGlndF9nZXRfY2Fpcm9fc3VyZmFj
ZShjaGFtZWxpdW0tPmRybV9mZCwgZmIpOwo+ICAKPiAtCQkvKiBHcmFiIHRoZSBjYXB0dXJlZCBm
cmFtZSBmcm9tIGNoYW1lbGl1bSAqLwo+ICsJCS8qIEdyYWIgdGhlIGNhcHR1cmVkIGZyYW1lIGZy
b20gdGhlIENoYW1lbGl1bS4gKi8KPiAgCQlmcmFtZSA9IGNoYW1lbGl1bV9yZWFkX2NhcHR1cmVk
X2ZyYW1lKGNoYW1lbGl1bSwgaW5kZXgpOwo+ICAJCWlndF9hc3NlcnQoZnJhbWUpOwo+ICAKPiAr
CQkvKiBDb252ZXJ0IHRoZSBjYXB0dXJlZCBmcmFtZSB0byBjYWlyby4gKi8KPiAgCQljYXB0dXJl
ID0gY29udmVydF9mcmFtZV9kdW1wX2FyZ2IzMihmcmFtZSk7Cj4gKwkJaWd0X2Fzc2VydChjYXB0
dXJlKTsKPiAgCj4gLQkJcmVmZXJlbmNlX3N1ZmZpeCA9IGlndF9jcmNfdG9fc3RyaW5nX2V4dGVu
ZGVkKHJlZmVyZW5jZV9jcmMsCj4gLQkJCQkJCQkgICAgICAnLScsIDIpOwo+IC0JCWNhcHR1cmVf
c3VmZml4ID0gaWd0X2NyY190b19zdHJpbmdfZXh0ZW5kZWQoY2FwdHVyZV9jcmMsICctJywKPiAt
CQkJCQkJCSAgICAyKTsKPiAtCj4gLQkJLyogV3JpdGUgcmVmZXJlbmNlIGFuZCBjYXB0dXJlIGZy
YW1lcyB0byBwbmcgKi8KPiAtCQlpZ3Rfd3JpdGVfY29tcGFyZWRfZnJhbWVzX3RvX3BuZyhyZWZl
cmVuY2UsIGNhcHR1cmUsCj4gLQkJCQkJCSByZWZlcmVuY2Vfc3VmZml4LAo+IC0JCQkJCQkgY2Fw
dHVyZV9zdWZmaXgpOwo+IC0KPiAtCQlmcmVlKHJlZmVyZW5jZV9zdWZmaXgpOwo+IC0JCWZyZWUo
Y2FwdHVyZV9zdWZmaXgpOwo+ICsJCWNvbXBhcmVkX2ZyYW1lc19kdW1wKHJlZmVyZW5jZSwgY2Fw
dHVyZSwgcmVmZXJlbmNlX2NyYywKPiArCQkJCSAgICAgY2FwdHVyZV9jcmMpOwo+ICAKPiAgCQlj
YWlyb19zdXJmYWNlX2Rlc3Ryb3kocmVmZXJlbmNlKTsKPiAgCQljYWlyb19zdXJmYWNlX2Rlc3Ry
b3koY2FwdHVyZSk7Cj4gQEAgLTEwODcsOCArMTExMyw2IEBAIHZvaWQKPiBjaGFtZWxpdW1fYXNz
ZXJ0X2FuYWxvZ19mcmFtZV9tYXRjaF9vcl9kdW1wKHN0cnVjdCBjaGFtZWxpdW0gKmNoYW1lbGl1
bSwKPiAgCWNhaXJvX3N1cmZhY2VfdCAqY2FwdHVyZTsKPiAgCWlndF9jcmNfdCAqcmVmZXJlbmNl
X2NyYzsKPiAgCWlndF9jcmNfdCAqY2FwdHVyZV9jcmM7Cj4gLQljaGFyICpyZWZlcmVuY2Vfc3Vm
Zml4Owo+IC0JY2hhciAqY2FwdHVyZV9zdWZmaXg7Cj4gIAlib29sIG1hdGNoOwo+ICAKPiAgCS8q
IEdyYWIgdGhlIHJlZmVyZW5jZSBmcmFtZSBmcm9tIGZyYW1lYnVmZmVyICovCj4gQEAgLTEwOTks
MjcgKzExMjMsMTkgQEAgdm9pZAo+IGNoYW1lbGl1bV9hc3NlcnRfYW5hbG9nX2ZyYW1lX21hdGNo
X29yX2R1bXAoc3RydWN0IGNoYW1lbGl1bSAqY2hhbWVsaXVtLAo+ICAKPiAgCW1hdGNoID0gaWd0
X2NoZWNrX2FuYWxvZ19mcmFtZV9tYXRjaChyZWZlcmVuY2UsIGNhcHR1cmUpOwo+ICAJaWYgKCFt
YXRjaCAmJiBpZ3RfZnJhbWVfZHVtcF9pc19lbmFibGVkKCkpIHsKPiAtCQlyZWZlcmVuY2VfY3Jj
ID0gY2hhbWVsaXVtX2NhbGN1bGF0ZV9mYl9jcmMoY2hhbWVsaXVtLT5kcm1fZmQsCj4gLQkJCQkJ
CQkgICBmYik7Cj4gLQkJY2FwdHVyZV9jcmMgPSBjaGFtZWxpdW1fZ2V0X2NyY19mb3JfYXJlYShj
aGFtZWxpdW0sIHBvcnQsIDAsCj4gMCwKPiAtCQkJCQkJCSAwLCAwKTsKPiArCQlyZWZlcmVuY2Vf
Y3JjID0gbWFsbG9jKHNpemVvZihpZ3RfY3JjX3QpKTsKCk5lZWQgYW4gaWd0X2Fzc2VydChyZWZl
cmVuY2VfY3JjKSBoZXJlLiBXaXRoIHRoYXQgZml4ZWQ6CgpSZXZpZXdlZC1ieTogTHl1ZGUgUGF1
bCA8bHl1ZGVAcmVkaGF0LmNvbT4KCj4gIAo+IC0JCWlndF9kZWJ1ZygiUmVmZXJlbmNlIENSQzog
JXNcbiIsCj4gLQkJCSAgaWd0X2NyY190b19zdHJpbmcocmVmZXJlbmNlX2NyYykpOwo+IC0JCWln
dF9kZWJ1ZygiQ2FwdHVyZWQgQ1JDOiAlc1xuIiwKPiBpZ3RfY3JjX3RvX3N0cmluZyhjYXB0dXJl
X2NyYykpOwo+ICsJCS8qIENhbGN1bGF0ZSB0aGUgcmVmZXJlbmNlIGZyYW1lIENSQy4gKi8KPiAr
CQljaGFtZWxpdW1fZG9fY2FsY3VsYXRlX2ZiX2NyYyhyZWZlcmVuY2UsIHJlZmVyZW5jZV9jcmMp
Owo+ICAKPiAtCQlyZWZlcmVuY2Vfc3VmZml4ID0gaWd0X2NyY190b19zdHJpbmdfZXh0ZW5kZWQo
cmVmZXJlbmNlX2NyYywKPiAtCQkJCQkJCSAgICAgICctJywgMik7Cj4gLQkJY2FwdHVyZV9zdWZm
aXggPSBpZ3RfY3JjX3RvX3N0cmluZ19leHRlbmRlZChjYXB0dXJlX2NyYywgJy0nLAo+IC0JCQkJ
CQkJICAgIDIpOwo+ICsJCS8qIEdldCB0aGUgY2FwdHVyZWQgZnJhbWUgQ1JDIGZyb20gdGhlIENo
YW1lbGl1bS4gKi8KPiArCQljYXB0dXJlX2NyYyA9IGNoYW1lbGl1bV9nZXRfY3JjX2Zvcl9hcmVh
KGNoYW1lbGl1bSwgcG9ydCwgMCwKPiAwLAo+ICsJCQkJCQkJIDAsIDApOwo+ICsJCWlndF9hc3Nl
cnQoY2FwdHVyZV9jcmMpOwo+ICAKPiAtCQkvKiBXcml0ZSByZWZlcmVuY2UgYW5kIGNhcHR1cmUg
ZnJhbWVzIHRvIHBuZyAqLwo+IC0JCWlndF93cml0ZV9jb21wYXJlZF9mcmFtZXNfdG9fcG5nKHJl
ZmVyZW5jZSwgY2FwdHVyZSwKPiAtCQkJCQkJIHJlZmVyZW5jZV9zdWZmaXgsCj4gLQkJCQkJCSBj
YXB0dXJlX3N1ZmZpeCk7Cj4gKwkJY29tcGFyZWRfZnJhbWVzX2R1bXAocmVmZXJlbmNlLCBjYXB0
dXJlLCByZWZlcmVuY2VfY3JjLAo+ICsJCQkJICAgICBjYXB0dXJlX2NyYyk7Cj4gIAo+IC0JCWZy
ZWUocmVmZXJlbmNlX3N1ZmZpeCk7Cj4gLQkJZnJlZShjYXB0dXJlX3N1ZmZpeCk7Cj4gIAkJZnJl
ZShyZWZlcmVuY2VfY3JjKTsKPiAgCQlmcmVlKGNhcHR1cmVfY3JjKTsKPiAgCX0KLS0gCkNoZWVy
cywKCUx5dWRlIFBhdWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=